Make WordPress Core

Opened 4 weeks ago

Closed 3 weeks ago

Last modified 3 weeks ago

#62414 closed enhancement (fixed)

Update "Call to Action" to "Call to action" for pattern category

Reported by: juanfra's profile juanfra Owned by:
Milestone: 6.8 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch
Focuses: ui-copy Cc:

Description

The original issue was reported by @joen here.

The idea is to update the "Call to Action" pattern category, to "Call to action" using sentence case and not title case. This would add cohesion with the other strings we have.

Change History (8)

This ticket was mentioned in PR #7794 on WordPress/wordpress-develop by @juanfra.


4 weeks ago
#1

  • Keywords has-patch added

@narenin commented on PR #7794:


4 weeks ago
#2

@juanfra Good catch!
This PR looks good to me.

#3 @mukesh27
3 weeks ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 6.8

Thanks for ticket and PR. It's small change looks good to me and ready for commit.

#4 @desrosj
3 weeks ago

  • Keywords commit removed
  • Milestone changed from 6.8 to 6.7.1

It seems there may be a few instances of Call to Action remaining in Gutenberg. Could we open a ticket to fix those upstream?

Twenty Twenty-Four Twenty Sixteen, and Twenty Twenty also have instances of this. I think separate ticket would be best for updating those.

#5 @desrosj
3 weeks ago

  • Keywords commit added

Unintentionally removed commit.

#6 @desrosj
3 weeks ago

In 59412:

Editor: Use sentence casing for “Call to action”.

This is more consistent with other strings and occurrences of this string.

Props juanfra, joen, narenin, mukesh27.
See #62414.

#7 @desrosj
3 weeks ago

  • Keywords commit removed
  • Milestone changed from 6.7.1 to 6.8
  • Resolution set to fixed
  • Status changed from new to closed

I am going to move this to 6.8 and close this out.

In general, the aim in minor releases is to update as few files as possible. Because this string is not a typo and does not change the meaning of the string, I'm not sure it should be included in a 6.7.x release. Especially since the string would need to be re-translated because there are no other occurrences of "Call to action" currently according to Glotpress.

If this is not the case and the capitalization does affect how it would be translated in another language (acknowledging I am mono-lingual at best), this can be reconsidered for a 6.7.x minor release.

#8 @juanfra
3 weeks ago

Thanks @desrosj - 6.8 sounds good to me.

I will create the tickets for the other instances and open new PRs for those.

Note: See TracTickets for help on using tickets.