Make WordPress Core

Opened 18 months ago

Last modified 3 months ago

#62437 new defect (bug)

Bundled Themes: Edit package-related details in block theme PHP files

Reported by: viralsampat's profile viralsampat Owned by:
Milestone: 7.1 Priority: lowest
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: docs, coding-standards Cc:

Description (last modified by sabernhardt)

Hello Team,

I have checked wp-admin & wp-includes folders and found few PHPcs fixes.

  • There must be exactly one blank line after the file comment
  • Missing @package tag in file comment

I have applied a patch which will fix this issue.

Thanks,

Attachments (5)

62437.patch (18.2 KB) - added by viralsampat 18 months ago.
I have checked above mentioned issue and founds few files. Here, I have added its patch.
62437.2.patch (55.8 KB) - added by viralsampat 18 months ago.
I have checked themes and found few files where we need to fix phpcs coding standard. Here, I have attached its patch.
62437.3.patch (16.3 KB) - added by viralsampat 17 months ago.
I have checked wp-admin and wp-includes folder and founds few files where we need to make this change, I have added its patch.
62437.4.patch (48.8 KB) - added by viralsampat 17 months ago.
I have checked themes and found few files where we need to fix phpcs coding standard. Here, I have attached its patch.
62437.diff (942 bytes) - added by sachinrajcp123 10 months ago.

Download all attachments as: .zip

Change History (23)

@viralsampat
18 months ago

I have checked above mentioned issue and founds few files. Here, I have added its patch.

This ticket was mentioned in Slack in #core by desrosj. View the logs.


18 months ago

#2 @desrosj
18 months ago

  • Keywords dev-feedback needs-testing removed
  • Milestone changed from Awaiting Review to 6.8
  • Priority changed from normal to lowest

@viralsampat
18 months ago

I have checked themes and found few files where we need to fix phpcs coding standard. Here, I have attached its patch.

#3 @SergeyBiryukov
18 months ago

  • Component changed from General to Bundled Theme
  • Summary changed from The wp-admin and wp-includes wordpress core: PHPCS Fixes to Bundled Themes: PHPCS Fixes

@viralsampat
17 months ago

I have checked wp-admin and wp-includes folder and founds few files where we need to make this change, I have added its patch.

@viralsampat
17 months ago

I have checked themes and found few files where we need to fix phpcs coding standard. Here, I have attached its patch.

#4 @poena
17 months ago

I have not been able to follow the similar tickets that have already been merged; but I think that theme changes and changes to wp-admin and wp-includes should be handled in separate issues?

Question, why is the subpackage included in Twenty Twenty-Four but not in Twenty Twenty-Three?

#5 @sabernhardt
16 months ago

  • Description modified (diff)
  • Focuses docs added
  • Summary changed from Bundled Themes: PHPCS Fixes to Bundled Themes: Edit package-related details in block theme PHP files

I revised the summary and description to focus on package-related information in bundled block theme PHP files, even though this ticket was originally about wp-admin and wp-includes.

  • 62437.patch edits 49 files outside bundled themes, not all related, including some external libraries.
  • 62437.2.patch edits 106 files in bundled themes, including 38 that are already part of #62166 and its PR.
  • 62437.3.patch edits 15 files outside bundled themes, not all related, including some external libraries.

62437.4.patch proposes (incomplete) changes to

  • 57 files in twentytwentyfour/patterns
    * @package WordPress
    * @subpackage Twenty_Twenty_Four
    
  • 7 files in twentytwentythree/patterns
    * @package WordPress
    

Current status of the PHP files:

  • TT5 has package, subpackage and since in functions.php and all its block patterns (plus these details are aligned in the hidden-written-by and text-faqs patterns).
  • TT4 only identifies the package and since version in the functions.php file, and the naming is not consistent with other themes. "Twenty Twenty-Four" is the package name, while other themes are subpackages of WordPress, and the name has a space and a hyphen instead of underscores. None of the theme's pattern files have these details.
  • TT3 has package, subpackage and since in functions.php but none of this information in the theme's seven block patterns.
  • TT2 has package, subpackage and since in functions.php and only the since version in the pattern registration file (inc/block-patterns.php). None of the theme's individual pattern files have these details.

#6 @desrosj
15 months ago

  • Keywords changes-requested added

@viralsampat are you able to refresh your patch to adress the feedback from @sabernhardt above?

This ticket was mentioned in PR #8379 on WordPress/wordpress-develop by @shailu25.


15 months ago
#7

Added Missing Package Details in Twenty Twenty Two, Twenty Twenty Three and Twenty Twenty Four Themes

Trac Ticket: 62437

#8 @shailu25
15 months ago

  • Keywords changes-requested removed

Added Changes as per Suggested in Above Comment

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


14 months ago

#10 @audrasjb
14 months ago

  • Milestone changed from 6.8 to 6.9

Moving to 6.9 as this task has a very low priority

#11 @shailu25
10 months ago

Refreshed Patch with the Latest Trunk. 8379

#12 @sachinrajcp123
10 months ago

I have added its patch

@shailu25 commented on PR #8379:


9 months ago
#13

Rebased with Latest Trunk.

#14 @shailu25
7 months ago

Refreshed Patch with the Latest Trunk. 8379

#15 @wildworks
7 months ago

The patch looks good, but since the RC1 release is coming soon, I'm puting this ticket to 7.0. However, if you're ready to commit, feel free to go ahead.

#16 @wildworks
6 months ago

  • Milestone changed from 6.9 to 7.0

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


3 months ago

#18 @sabernhardt
3 months ago

  • Milestone changed from 7.0 to 7.1

Moving to consider this for a later milestone. Twenty Twenty-Two and Twenty Twenty-Three might not need a new release packaged with 7.0 (they only updated the copyright year and/or 'Tested up to' since their last releases).

Note: See TracTickets for help on using tickets.