Bundled Themes: Edit package-related details in block theme PHP files

[viralsampat]

Hello Team,

I have checked wp-admin & wp-includes folders and found few PHPcs fixes.

• There must be exactly one blank line after the file comment
• Missing @package tag in file comment

I have applied a patch which will fix this issue.

Thanks,

[viralsampat]

I have checked above mentioned issue and founds few files. Here, I have added its patch.

[viralsampat]

I have checked themes and found few files where we need to fix phpcs coding standard. Here, I have attached its patch.

[viralsampat]

I have checked wp-admin and wp-includes folder and founds few files where we need to make this change, I have added its patch.

[viralsampat]

I have checked themes and found few files where we need to fix phpcs coding standard. Here, I have attached its patch.

[poena]

I have not been able to follow the similar tickets that have already been merged; but I think that theme changes and changes to wp-admin and wp-includes should be handled in separate issues?

Question, why is the subpackage included in Twenty Twenty-Four but not in Twenty Twenty-Three?

[sabernhardt]

I revised the summary and description to focus on package-related information in bundled block theme PHP files, even though this ticket was originally about wp-admin and wp-includes.

• 62437.patch edits 49 files outside bundled themes, not all related, including some external libraries.
• 62437.2.patch edits 106 files in bundled themes, including 38 that are already part of #62166 and its PR.
• 62437.3.patch edits 15 files outside bundled themes, not all related, including some external libraries.

62437.4.patch proposes (incomplete) changes to

• 57 files in twentytwentyfour/patterns

  * @package WordPress
  * @subpackage Twenty_Twenty_Four
  

• 7 files in twentytwentythree/patterns

  * @package WordPress
  

---

Current status of the PHP files:

• TT5 has package, subpackage and since in functions.php and all its block patterns (plus these details are aligned in the hidden-written-by and text-faqs patterns).
• TT4 only identifies the package and since version in the functions.php file, and the naming is not consistent with other themes. "Twenty Twenty-Four" is the package name, while other themes are subpackages of WordPress, and the name has a space and a hyphen instead of underscores. None of the theme's pattern files have these details.
• TT3 has package, subpackage and since in functions.php but none of this information in the theme's seven block patterns.
• TT2 has package, subpackage and since in functions.php and only the since version in the pattern registration file (inc/block-patterns.php). None of the theme's individual pattern files have these details.

[desrosj]

@viralsampat are you able to refresh your patch to adress the feedback from @sabernhardt above?

Added Missing Package Details in Twenty Twenty Two, Twenty Twenty Three and Twenty Twenty Four Themes

Trac Ticket: 62437

[shailu25]

Added Changes as per Suggested in Above Comment

[audrasjb]

Moving to 6.9 as this task has a very low priority

[shailu25]

Refreshed Patch with the Latest Trunk. ​8379

[sachinrajcp123]

I have added its patch

Rebased with Latest Trunk.

[shailu25]

Refreshed Patch with the Latest Trunk. ​8379

[wildworks]

The patch looks good, but since the RC1 release is coming soon, I'm puting this ticket to 7.0. However, if you're ready to commit, feel free to go ahead.

[sabernhardt]

Moving to consider this for a later milestone. Twenty Twenty-Two and Twenty Twenty-Three might not need a new release packaged with 7.0 (they only updated the copyright year and/or 'Tested up to' since their last releases).

[sabernhardt]

PR 8379 looks ready for commit.

[wildworks]

​PR 8379 has already been approved, and I will review it again and commit it for the 7.1 release.

Just to be sure, I've checked this PR again and found no issues, so I'm committing it.

[wildworks]

In 62867:

Bundled Themes: Add missing package details to block themes.

This adds the @package, @subpackage, and @since tags to the block pattern files of Twenty Twenty-Two, Twenty Twenty-Three, and Twenty Twenty-Four, and corrects Twenty Twenty-Four's functions.php to use the @package WordPress form consistent with the other bundled themes.

Props poena, sabernhardt, shailu25, viralsampat, wildworks.
Fixes #62437.

I cannot close this, but the changes were committed in r62867.

Sorry, I forgot to close this.