Make WordPress Core

Opened 2 months ago

Last modified 11 hours ago

#62437 new defect (bug)

Bundled Themes: Edit package-related details in block theme PHP files

Reported by: viralsampat's profile viralsampat Owned by:
Milestone: 6.8 Priority: lowest
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: docs, coding-standards Cc:

Description (last modified by sabernhardt)

Hello Team,

I have checked wp-admin & wp-includes folders and found few PHPcs fixes.

  • There must be exactly one blank line after the file comment
  • Missing @package tag in file comment

I have applied a patch which will fix this issue.

Thanks,

Attachments (4)

62437.patch (18.2 KB) - added by viralsampat 2 months ago.
I have checked above mentioned issue and founds few files. Here, I have added its patch.
62437.2.patch (55.8 KB) - added by viralsampat 7 weeks ago.
I have checked themes and found few files where we need to fix phpcs coding standard. Here, I have attached its patch.
62437.3.patch (16.3 KB) - added by viralsampat 3 weeks ago.
I have checked wp-admin and wp-includes folder and founds few files where we need to make this change, I have added its patch.
62437.4.patch (48.8 KB) - added by viralsampat 3 weeks ago.
I have checked themes and found few files where we need to fix phpcs coding standard. Here, I have attached its patch.

Download all attachments as: .zip

Change History (9)

@viralsampat
2 months ago

I have checked above mentioned issue and founds few files. Here, I have added its patch.

This ticket was mentioned in Slack in #core by desrosj. View the logs.


2 months ago

#2 @desrosj
2 months ago

  • Keywords dev-feedback needs-testing removed
  • Milestone changed from Awaiting Review to 6.8
  • Priority changed from normal to lowest

@viralsampat
7 weeks ago

I have checked themes and found few files where we need to fix phpcs coding standard. Here, I have attached its patch.

#3 @SergeyBiryukov
5 weeks ago

  • Component changed from General to Bundled Theme
  • Summary changed from The wp-admin and wp-includes wordpress core: PHPCS Fixes to Bundled Themes: PHPCS Fixes

@viralsampat
3 weeks ago

I have checked wp-admin and wp-includes folder and founds few files where we need to make this change, I have added its patch.

@viralsampat
3 weeks ago

I have checked themes and found few files where we need to fix phpcs coding standard. Here, I have attached its patch.

#4 @poena
13 days ago

I have not been able to follow the similar tickets that have already been merged; but I think that theme changes and changes to wp-admin and wp-includes should be handled in separate issues?

Question, why is the subpackage included in Twenty Twenty-Four but not in Twenty Twenty-Three?

#5 @sabernhardt
11 hours ago

  • Description modified (diff)
  • Focuses docs added
  • Summary changed from Bundled Themes: PHPCS Fixes to Bundled Themes: Edit package-related details in block theme PHP files

I revised the summary and description to focus on package-related information in bundled block theme PHP files, even though this ticket was originally about wp-admin and wp-includes.

  • 62437.patch edits 49 files outside bundled themes, not all related, including some external libraries.
  • 62437.2.patch edits 106 files in bundled themes, including 38 that are already part of #62166 and its PR.
  • 62437.3.patch edits 15 files outside bundled themes, not all related, including some external libraries.

62437.4.patch proposes (incomplete) changes to

  • 57 files in twentytwentyfour/patterns
    * @package WordPress
    * @subpackage Twenty_Twenty_Four
    
  • 7 files in twentytwentythree/patterns
    * @package WordPress
    

Current status of the PHP files:

  • TT5 has package, subpackage and since in functions.php and all its block patterns (plus these details are aligned in the hidden-written-by and text-faqs patterns).
  • TT4 only identifies the package and since version in the functions.php file, and the naming is not consistent with other themes. "Twenty Twenty-Four" is the package name, while other themes are subpackages of WordPress, and the name has a space and a hyphen instead of underscores. None of the theme's pattern files have these details.
  • TT3 has package, subpackage and since in functions.php but none of this information in the theme's seven block patterns.
  • TT2 has package, subpackage and since in functions.php and only the since version in the pattern registration file (inc/block-patterns.php). None of the theme's individual pattern files have these details.
Note: See TracTickets for help on using tickets.