Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 18 months ago

#62443 closed defect (bug) (duplicate)

Horizontal overflow on customizer panel allows horizontal scrolling

Reported by: kharisblank Owned by:
Priority: normal Milestone:
Component: Customize Version: 6.7
Severity: normal Keywords: has-screenshots has-test-info has-patch
Cc: Focuses: ui, accessibility, css

Description

The customizer panel now has horizontal overflow, that allows horizontal scrolling, which did not happen before.

https://cldup.com/j0s3FKzM3q.gif

https://cldup.com/gUDx_NnZbp.png

I am testing out with:

  • WordPress 6.7
  • Twenty Seventeen theme, version 3.8
  • No active plugin

Change History (8)

#1 follow-up: @sainathpoojary
2 years ago

  • Keywords has-testing-info added; needs-testing removed

Hi @kharisblank,

Thank you for bringing this up. I tested it and was able to successfully reproduce the issue.

https://utfs.io/f/PL8E4NiPUWyOMrlYPPyhp3F90beESqliHBLy7PKXG5nvmwjA

#2 in reply to: ↑ 1 ; follow-up: @kharisblank
2 years ago

Replying to sainathpoojary:

Hi @sainathpoojary,

Thanks for testing out this issue.

This ticket was mentioned in ​PR #7811 on ​WordPress/wordpress-develop by ​@sainathpoojary.


2 years ago
#3

  • Keywords has-patch added

Trac ticket: #62443

This PR addresses the issue of horizontal overflow in the customizer panel, which was causing unintended horizontal scrolling. The overflow issue has been resolved by modifying the overflow-x to ensure the panel content stays within the bounds of the viewport.

### Screenshots:
https://github.com/user-attachments/assets/464cdf70-3a70-452b-a46c-735cf7780d4f
https://github.com/user-attachments/assets/ef8d30ff-c254-4660-bae1-9d4f292d29d9

#4 in reply to: ↑ 2 @sainathpoojary
2 years ago

Hey @kharisblank,

I have created a pull request with a solution which fixes this issue.

​@kharisblank commented on ​PR #7811:


2 years ago
#5

Hi @SainathPoojary,

Thanks for your attempt to fix this issue with your code addition, which visually resolves it.

However, upon further inspection, the root of this issue may be related to previous accessibility improvement for accordion component. See ​this CSS update for reference.

This added extra padding in that code part makes the customizer control button a little longer than usual.

padding: 10px 10px 11px 14px;

https://github.com/user-attachments/assets/53a2694e-8079-4a7a-8afe-3a7a0baa0963

That being said, the better fix would be adding box sizing to the button:

.accordion-section-title button.accordion-trigger {
     box-sizing: border-box;
}

What do you think?

​@sainathpoojary commented on ​PR #7811:


2 years ago
#6

Hi @kharissulistiyo ,

Thank you for your feedback and for pointing out the root cause.

I agree that adding box-sizing: border-box; to the button is a more robust solution to ensure the customizer control button sizing remains consistent, and it should resolve the overflow issue without impacting the layout further.

I’ll update the code to include this change. Thanks again for the suggestion!

#7 @sabernhardt
2 years ago

  • Milestone Awaiting Review
  • Resolution → duplicate
  • Status new → closed
  • Type enhancement → defect (bug)
  • Version → 6.7

#62313 is already tracking the horizontal scroll issue, and I think it needs more than the box-sizing update. Please join the discussion on the other ticket.

#8 @wordpressdotorg
18 months ago

  • Keywords has-test-info added; has-testing-info removed
Note: See TracTickets for help on using tickets.