![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 20 months ago
Last modified 20 months ago
#62463 new defect (bug)
The `precommit:emoji` script no longer works in branches 6.4 and earlier
| Reported by: | johnbillion | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Awaiting Review |
| Component: | Build/Test Tools | Version: | |
| Severity: | normal | Keywords: | |
| Cc: | Focuses: |
Description
In r57758 the precommit:emoji script was updated to fetch the list of Twemoji files via a GraphQL query to the jdecked/twemoji repo.
This script in branches 6.4 and earlier still tries to fetch the list from the trunk branch of the twitter/twemoji repo. The trunk branch no longer exists, therefore this command fails.
r57758 should be backported.
Previously:
Change History (3)
#2
follow-up:
↓ 3
@
20 months ago
No I don't think there is, but it gets run as part of npm run grunt:precommit.
#3
in reply to: ↑ 2
@
20 months ago
Replying to johnbillion:
No I don't think there is, but it gets run as part of
npm run grunt:precommit.
Is it worth considering removing the emoji step from the older branches?
As people love emoji, it can serve as a motivation to update to the supported version of WP. Although this might make life hard fro the security team if an issue is found in the emoji library.
Are there any scenarios where the Twemoji library should be updated in these older branches?