WordPress.org
Get WordPress

Make WordPress Core

Opened 3 weeks ago

Closed 3 weeks ago

Last modified 3 weeks ago

#62465 closed defect (bug) (fixed)

Remove redundant server state from Interactivity Router

Reported by: czapla's profile czapla Owned by: desrosj's profile desrosj
Milestone: 6.7.1 Priority: normal
Severity: normal Version: 6.7
Component: Interactivity API Keywords: has-patch commit fixed-major dev-reviewed
Focuses: Cc:

Description

Remove the workaround for a bug that was fixed in ​https://github.com/WordPress/gutenberg/pull/66183.

Previously, if the store was not initialized with a minimal navigation object, the interactivity-router script module would error.

Change History (8)

#2 @czapla
3 weeks ago

  • Resolution set to fixed
  • Status changed from new to closed

Committed in [59416].

This ticket was mentioned in ​Slack in #core by desrosj. ​View the logs.
3 weeks ago

#5 @desrosj
3 weeks ago

  • Keywords fixed-major dev-feedback added
  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Summary changed from Interactivity API: Remove redundant server state from Interactivity Router to Remove redundant server state from Interactivity Router

Reopening to consider backporting.

#6 @desrosj
3 weeks ago

  • Keywords dev-reviewed added; dev-feedback removed
  • Version changed from trunk to 6.7

[59416] looks good to backport.

#7 @desrosj
3 weeks ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from reopened to closed

In 59436:

Interactivity API: Remove redundant server state from Interactivity Router.

Remove the workaround for a bug that was fixed in ​https://github.com/WordPress/gutenberg/pull/66183. Previously, if the store was not initialized with a minimal navigation object, the interactivity-router script module would error.

Reviewed by desrosj.
Merges [59416] to the 6.7 branch.

Props jonsurrell, czapla, gziolo.
Fixes #62465.

#8 @desrosj
3 weeks ago

  • Type changed from enhancement to defect (bug)

It seems the other code changes relevant to this were shipped in 6.7, and this was overlooked /left out. Reclassifying as a bug to account for that.

Note: See TracTickets for help on using tickets.