Make WordPress Core

Opened 3 weeks ago

Last modified 2 weeks ago

#62482 new enhancement

Improve text strings in Twenty Twenty-Five

Reported by: poena's profile poena Owned by:
Milestone: 6.7.2 Priority: normal
Severity: normal Version: 6.7
Component: Bundled Theme Keywords: good-first-bug has-patch
Focuses: Cc:

Description

This ticket replaces GitHub issue 671 that was not solved in time before the release of the theme.

Translators have provided feedback that there are duplicate strings because
the theme adds translators contexts inconsistently.

Examples:
"Learn more" without context
"Learn more" with the context "Sample hero button"
"Learn more" with the context "Button text of intro section."

"Search" with the context "Button text. Verb"
"Search" with the context "Button text. Verb."

Which means that the text "Learn more" is added 3 times and "Search" two times.


In addition, after looking at some of the translations that have been added, it is my opinion that some of the pattern names and template part names could be improved to make them easier to translate.

For example, this pattern name clearly explains that it is a page template:
"Page template for the right-aligned blog" and this name explains that it is the search results:
"News blog search results"-
While this name "Right-aligned blog, search" may sound like it is referring to the word search as a verb.

"Vertical Header" has translators believing that "header" is referring to a heading/headline/title, and not an alternative site header template part.


There was also feedback shared on the WordPress Slack, saying that the theme is not following the
Style guide for writing documentation.

The style guide for quotation marks is to use straight quotes https://make.wordpress.org/docs/style-guide/punctuation/quotation-marks/

Example of where curly quotes are used:

twentytwentyfive\patterns\banner-poster.php

<?php
echo wp_kses_post(
/* translators: This string contains the word "Stories" in four different languages with the first item in the locale's language. */
_x( '“Stories, <span lang="es">historias</span>, <span lang="uk">iсторії</span>, <span lang="el">iστορίες</span>”', 'Placeholder heading in four languages.', 'twentytwentyfive' )
);
?>

Change History (4)

#1 @desrosj
3 weeks ago

  • Keywords needs-patch good-first-bug added
  • Milestone changed from 6.8 to 6.7.2

This ticket was mentioned in PR #7878 on WordPress/wordpress-develop by vasilpichurov.


2 weeks ago
#2

  • Keywords has-patch added; needs-patch removed

I have changed the context descriptions for problematic patterns. Now they should be consistent named across different patterns.

This ticket was mentioned in PR #7878 on WordPress/wordpress-develop by vasilpichurov.


2 weeks ago
#3

I have changed the context descriptions for problematic patterns. Now they should be consistent named across different patterns.

@dilip2615 commented on PR #7878:


2 weeks ago
#4

Yes, it's changed, the review from my side.

Note: See TracTickets for help on using tickets.