Make WordPress Core

Opened 4 months ago

Closed 4 weeks ago

Last modified 4 weeks ago

#62482 closed enhancement (fixed)

Improve text strings in Twenty Twenty-Five

Reported by: poena's profile poena Owned by: karmatosed's profile karmatosed
Milestone: 6.8 Priority: normal
Severity: normal Version: 6.7
Component: Bundled Theme Keywords: has-patch needs-testing commit
Focuses: Cc:

Description

This ticket replaces GitHub issue 671 that was not solved in time before the release of the theme.

Translators have provided feedback that there are duplicate strings because
the theme adds translators contexts inconsistently.

Examples:
"Learn more" without context
"Learn more" with the context "Sample hero button"
"Learn more" with the context "Button text of intro section."

"Search" with the context "Button text. Verb"
"Search" with the context "Button text. Verb."

Which means that the text "Learn more" is added 3 times and "Search" two times.


In addition, after looking at some of the translations that have been added, it is my opinion that some of the pattern names and template part names could be improved to make them easier to translate.

For example, this pattern name clearly explains that it is a page template:
"Page template for the right-aligned blog" and this name explains that it is the search results:
"News blog search results"-
While this name "Right-aligned blog, search" may sound like it is referring to the word search as a verb.

"Vertical Header" has translators believing that "header" is referring to a heading/headline/title, and not an alternative site header template part.


There was also feedback shared on the WordPress Slack, saying that the theme is not following the
Style guide for writing documentation.

The style guide for quotation marks is to use straight quotes https://make.wordpress.org/docs/style-guide/punctuation/quotation-marks/

Example of where curly quotes are used:

twentytwentyfive\patterns\banner-poster.php

<?php
echo wp_kses_post(
/* translators: This string contains the word "Stories" in four different languages with the first item in the locale's language. */
_x( '“Stories, <span lang="es">historias</span>, <span lang="uk">iсторії</span>, <span lang="el">iστορίες</span>”', 'Placeholder heading in four languages.', 'twentytwentyfive' )
);
?>

Attachments (2)

banner-poster.php (366 bytes) - added by hameem1102 2 months ago.
62482-improve-text.patch (494 bytes) - added by prathamesh24 6 weeks ago.
This patch improves the text strings in the Twenty Twenty-Five theme for better clarity and consistency.

Download all attachments as: .zip

Change History (28)

#1 @desrosj
4 months ago

  • Keywords needs-patch good-first-bug added
  • Milestone changed from 6.8 to 6.7.2

This ticket was mentioned in PR #7878 on WordPress/wordpress-develop by vasilpichurov.


4 months ago
#2

  • Keywords has-patch added; needs-patch removed

I have changed the context descriptions for problematic patterns. Now they should be consistent named across different patterns.

This ticket was mentioned in PR #7878 on WordPress/wordpress-develop by vasilpichurov.


4 months ago
#3

I have changed the context descriptions for problematic patterns. Now they should be consistent named across different patterns.

@dilip2615 commented on PR #7878:


4 months ago
#4

Yes, it's changed, the review from my side.

This ticket was mentioned in Slack in #core by jorbin. View the logs.


3 months ago

@desrosj commented on PR #7878:


3 months ago
#6

@vasilpichurov Are you able to address the feedback from @carolinan's review?

#7 @karmatosed
3 months ago

  • Keywords changes-requested added

#8 @burakkaptan
2 months ago

@poena @karmatosed @desrosj
Could you please assign this ticket to me? I will work on it until I indicate otherwise.
Thank you!

#9 @poena
2 months ago

@burakkaptan You are welcome to work on it, but please read the ticket history and comments, there are already two contributors working it. Perhaps you can find a way to collaborate.

Contributors are not assigned to tickets in this repository, but this does not limit who can work on a ticket, everyone is welcome.

@hameem1102 The file you submitted is not a complete patch.

Please see these documents that can help you solve this issue:
https://make.wordpress.org/core/handbook/tutorials/faq-for-new-contributors/
https://make.wordpress.org/core/handbook/tutorials/working-with-patches/

https://developer.wordpress.org/block-editor/reference-guides/block-api/block-patterns/
https://developer.wordpress.org/themes/patterns/

https://developer.wordpress.org/apis/internationalization/

#10 @burakkaptan
2 months ago

@poena I was under the impression that tickets are assigned to contributors. The FAQ page you shared clarified how things work. While I’ve read a lot of documentation related to the core, I hadn’t come across the FAQ page before. Thank you for pointing it out. I truly appreciate your guidance.

Let the other two contributors continue working on the issue.I’d be happy to work on other issues instead.

This ticket was mentioned in Slack in #core by jorbin. View the logs.


2 months ago

This ticket was mentioned in Slack in #core by jorbin. View the logs.


2 months ago

#13 @jorbin
2 months ago

  • Milestone changed from 6.7.2 to 6.8

Moving to 6.8 since the patch isn't ready but once this is ready we can consider a twenty-twentyfive only release.

@prathamesh24
6 weeks ago

This patch improves the text strings in the Twenty Twenty-Five theme for better clarity and consistency.

#14 @prathamesh24
6 weeks ago

My previous patch focused on improving general text clarity,
but I see that additional improvements are needed for translation context and pattern names.
I will update the patch to include these changes, ensuring better clarity for translators
and improving pattern descriptions. Let me know if there are any other areas I should focus on!

Last edited 6 weeks ago by prathamesh24 (previous) (diff)

#15 @poena
6 weeks ago

I don't understand. What previous patch? @prathamesh24 do you have more than one username?
62482-improve-text.patch is not a patch.
Please refer to the links in comment 9 about how to work with patches.

This ticket was mentioned in PR #8314 on WordPress/wordpress-develop by @poena.


6 weeks ago
#16

In Twenty Twenty-Five:

  • Remove the unnecessary context from some text strings where the translatable text was the same but the context was different. This reduces the number of strings a translator needs to work with.
  • Use straight double quotes and straight apostrophes, to follow the documentation standards.
  • Update the name of headers, to make it easier for translators to understand that they are site headers not headings.
  • Update the name of templates to make the naming more consistent. Example:

Title: Text-only blog, home is now Title: Text blog home to match Title: News blog home etc.

Trac ticket: https://core.trac.wordpress.org/ticket/62482

#17 @poena
5 weeks ago

  • Keywords needs-testing added; good-first-bug changes-requested removed

#18 @audrasjb
5 weeks ago

I left a few comments in the PR :)
The idea is to avoid escaped characters as much as possible, to simplify polyglot's work.

This ticket was mentioned in PR #8397 on WordPress/wordpress-develop by @poena.


4 weeks ago
#19

In Twenty Twenty-Five:

Remove the unnecessary context from some text strings where the translatable text was the same but the context was different. This reduces the number of strings a translator needs to work with.

Update the name of headers, to make it easier for translators to understand that they are site headers not headings.
Update the name of templates to make the naming more consistent.
Example:
Title: Text-only blog, home is now Title: Text blog home to match Title: News blog home etc.

Trac ticket: https://core.trac.wordpress.org/ticket/62482

This ticket was mentioned in Slack in #core-test by krupajnanda. View the logs.


4 weeks ago

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


4 weeks ago

#22 @audrasjb
4 weeks ago

@poena the last PR looks good to me. I think it's ready for commit.
However we'll need to get this committed before beta 1, so Monday 3 is the deadline for this ticket before being punted to 6.9 :)

#23 @karmatosed
4 weeks ago

I can take this on and get in for commit. It feels a shame to not have that happen when it's so ready.

#24 @karmatosed
4 weeks ago

  • Owner set to karmatosed
  • Status changed from new to assigned

#25 @karmatosed
4 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 59891:

Twenty Twenty-Five: Improves text strings.

This ticket replaces the issue not resolved in time before the release of the theme. This now takes the feedback of translators and iterates on that.

Props poena, desrosj, hameem1102, burakkaptan, jorbin, prathamesh24, audrasjb.
Fixes #62482.

#26 @karmatosed
4 weeks ago

  • Keywords commit added
Note: See TracTickets for help on using tickets.