Make WordPress Core

Opened 8 weeks ago

Last modified 3 weeks ago

#62494 reopened defect (bug)

Some links on the left controls of theme customise non responsive

Reported by: paullb's profile paullb Owned by: joedolson's profile joedolson
Milestone: 6.7.2 Priority: normal
Severity: normal Version: 6.7
Component: Customize Keywords: has-patch commit fixed-major dev-feedback
Focuses: javascript Cc:

Description

Several of the theme customise tables on the left side controls are not responsive and cannot be opened. Meaning that the many of the attributes of the theme (e.g. custom CSS) cannot be edited.

Some menu items work and others do not. This situation has persisted for over a week now.

Clicking on them does nothing and nothing appears in the developer console.

No changes were made to plugins of browser or WordPress when these menu items suddenly became non functional.

Tried

  • Disabling plugins
  • Incognito window
  • Chrome and Brave

Attachments (4)

Screenshot 2024-11-21 at 7.33.44.png (748.8 KB) - added by paullb 8 weeks ago.
Screenshot 2024-11-21 at 8.52.02.png (725.3 KB) - added by paullb 8 weeks ago.
With console
62494.diff (2.6 KB) - added by joedolson 4 weeks ago.
Trigger accordions on section headers with tabindex, so custom code that matched the previous pattern still triggers.
62494.2.diff (2.6 KB) - added by jorbin 4 weeks ago.

Download all attachments as: .zip

Change History (21)

#1 @desrosj
8 weeks ago

  • Component changed from General to Customize
  • Keywords reporter-feedback added

Hi @paullb,

Thanks for this ticket, and welcome to Trac!

Could you share a bit more about your site. Are you running WordPress 6.7? Did this start after your site updated (6.7 was released on November 12th)? What theme are you using? Are there any browser console errors? Please share as many details as you can to help someone else reproduce the problem.

#2 @paullb
8 weeks ago

Thanks for taking the time to look at this.

Yup. WordPress 6.7 (sorry for forgetting to write that the first time)

I see some console issues (attached) on first load, but clicking on the non-responsive element does not generate additional console errors.

Did this start after your site updated (6.7 was released on November 12th)?

This timeline feels about right, but I can't remember the specific date of the last time I tried to customise the theme, so it could have been before that.

Hope that's helpful, anything else I can add?

@paullb
8 weeks ago

With console

#3 @desrosj
8 weeks ago

If you're comfortable and able to, could you try giving 6.7.1 RC1 a try? It's due out on the 21st, and there were a few Customizer related bug fixes. It would be good to know if they happen to resolve your problem.

Keep in mind, though, this is a development version and testing it out in a staging server is recommended. Full details here: https://make.wordpress.org/core/2024/11/20/wordpress-6-7-1-rc1-is-now-available/.

#4 @paullb
8 weeks ago

Thanks for that. I'll just wait for it to come out officially as there isn't a particularly urgent need to do anything immediately. I'll comment again here once 6.7.1 is installed and I can test!

#5 follow-up: @sabernhardt
8 weeks ago

  • Focuses javascript added
  • Keywords reporter-feedback removed
  • Milestone changed from Awaiting Review to 6.7.2
  • Version set to 6.7

This issue is separate from the CSS edits in #62313.

[59224] added button elements to activate each panel, but Hueman and some other themes have their own markup for the panel headings. Hueman authors are working to fix compatibility (see support topic).

Should the Customize script have an extra condition to activate when clicking the heading if it has a tabindex and/or lacks the .accordion-trigger button?

#6 @paullb
8 weeks ago

Looks like it might already be known but tested in 6.7.1 and problem persists.

Last edited 8 weeks ago by paullb (previous) (diff)

#7 @sabernhardt
7 weeks ago

#62552 was marked as a duplicate.

This ticket was mentioned in Slack in #core by jorbin. View the logs.


4 weeks ago

#9 in reply to: ↑ 5 @jorbin
4 weeks ago

  • Keywords needs-patch added

Replying to sabernhardt:

This issue is separate from the CSS edits in #62313.

[59224] added button elements to activate each panel, but Hueman and some other themes have their own markup for the panel headings. Hueman authors are working to fix compatibility (see support topic).

Should the Customize script have an extra condition to activate when clicking the heading if it has a tabindex and/or lacks the .accordion-trigger button?

This provides a potential path forward and a large list of themes to test with, I think it could use a patch.

#10 @joedolson
4 weeks ago

  • Owner set to joedolson
  • Status changed from new to accepted

@joedolson
4 weeks ago

Trigger accordions on section headers with tabindex, so custom code that matched the previous pattern still triggers.

#11 @joedolson
4 weeks ago

  • Keywords has-patch needs-testing has-testing-info added; needs-patch removed

I've tested this patch with Hueman version 3.7.25 (prior to their fixing this in their own code), but additional testing with other custom implementations would be useful.

Testing instructions:

1) Install a theme that implements custom interactive section headers in the customizer.
2) Verify that these do not work in 6.7.1 pre-patch.
3) Verify that they do work post-patch.

This ticket was mentioned in Slack in #core by jorbin. View the logs.


4 weeks ago

@jorbin
4 weeks ago

#13 @jorbin
4 weeks ago

  • Keywords commit added

I needed to refresh the patch to apply it to trunk, but tested and it seems to work for me on Hueman version 3.7.24. I also tested with 3.7.25 and twentynineteen and confirmed that it is the customizer controls are correctly there as well.

#15 @joedolson
3 weeks ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 59555:

Customizer: Allow custom accordion items with obsolete structure.

In [59224], customizer accordion item HTML structure was changed to include a button element as the interactive control. However, some themes inject custom markup for panel headings.

Fix controls.js to handle both the new markup and the old markup, which is relatively common in themes.

Props paullb, desrosj, sabernhardt, joedolson, jorbin.
Fixes #62494.

#16 @joedolson
3 weeks ago

  • Keywords fixed-major dev-feedback added; needs-testing has-testing-info removed
  • Resolution fixed deleted
  • Severity changed from blocker to normal
  • Status changed from closed to reopened

Reopening for backport to 6.7.2.

@joedolson commented on PR #8034:


3 weeks ago
#17

Fixed in r59555

Note: See TracTickets for help on using tickets.