Make WordPress Core

Opened 4 months ago

Closed 8 weeks ago

#62499 closed enhancement (fixed)

Number in "Add Themes" screen is misaligned and touches the border

Reported by: sukhendu2002's profile sukhendu2002 Owned by: audrasjb's profile audrasjb
Milestone: 6.8 Priority: low
Severity: minor Version:
Component: Themes Keywords: has-patch has-screenshots has-testing-info commit
Focuses: administration Cc:

Description

On the "Add Themes" screen in mobile view, the theme number displayed in the tab header is visually misaligned and touches the top border.

Attachments (4)

theme-count-mobile-view.png (333.8 KB) - added by sukhendu2002 4 months ago.
62499.2.patch (485 bytes) - added by diliphingarajiya 4 months ago.
fix-62499.mp4 (2.3 MB) - added by dhruvang21 4 months ago.
themes-count-design.png (985.6 KB) - added by rinkalpagdar 2 months ago.

Change History (16)

This ticket was mentioned in PR #7856 on WordPress/wordpress-develop by @sukhendu2002.


4 months ago
#1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/62499

This PR fixes the UI issue where the theme count in the "Add Themes" screen touches the border in mobile view.

https://github.com/user-attachments/assets/577cad00-3cc2-475d-8aa0-a52139ae4cbf

#2 @parthvataliya
4 months ago

  • Keywords has-screenshots added

#3 @diliphingarajiya
4 months ago

  • Keywords needs-testing added

I’ve updated the previous patch by adding a margin to the .filter-count instead of applying padding to the parent div. This ensures better spacing control while maintaining the parent div's original structure and dimensions.

#4 @dilipbheda
4 months ago

  • Keywords has-testing-info added

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/62499/62499.2.patch

Environment

  • WordPress: 6.8-alpha-59274-src
  • PHP: 8.2.25
  • Server: nginx/1.27.2
  • Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.25)
  • Browser: Chrome 130.0.0.0
  • OS: Linux
  • Theme: Twenty Twenty-Five 1.0
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.0

Actual Results

  1. ✅ Issue resolved with patch.

Additional Notes

  • I tested both patches, and it seems that 62499.2.patch works well for me.

#5 follow-up: @ankitkumarshah
4 months ago

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/62499/62499.2.patch

Environment

  • WordPress: 6.8-alpha-59422
  • PHP: 8.2.25
  • Server: Apache/2.4.62 (Debian)
  • Database: mysqli (Server: 11.4.4-MariaDB-ubu2404 / Client: mysqlnd 8.2.25)
  • Browser: Chrome 131.0.0.0
  • OS: macOS
  • Theme: Twenty Twenty-Five

Actual Results

  1. ✅ Issue resolved with patch.

Supplemental Artifacts

https://i.postimg.cc/JnZ51Q8T/BEFORE-PATCH.png

#6 @dhruvang21
4 months ago

Test Report

Description

This report validates that the indicated patch works as expected.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/62499/62499.2.patch

Environment

  • WordPress: 6.8-alpha-59274-src
  • PHP: 8.2.22
  • Server: nginx/1.27.0
  • Database: mysqli (Server: 8.0.39 / Client: mysqlnd 8.2.22)
  • Browser: Chrome 128.0.0.0 (Mobile)
  • OS: Android
  • Theme: Twenty Ten 4.3
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.0

Actual Results

  1. ✅ Issue resolved with patch.

Supplemental Artifacts

Added as Attachment

@dhruvang21
4 months ago

#7 @desrosj
4 months ago

  • Component changed from General to Themes
  • Focuses administration added; ui css removed
  • Milestone changed from Awaiting Review to 6.8
  • Priority changed from normal to low

#8 @sabernhardt
4 months ago

  • Version 6.7 deleted

I found the misalignment in English as early as 6.1, likely related to adding the Block Themes filter link (#56283). In French, the number could touch the border in 6.0.

#9 in reply to: ↑ 5 @im3dabasia1
4 months ago

Test Report

Description

This report validates whether the indicated patch works as expected.
Patch tested:  https://core.trac.wordpress.org/attachment/ticket/62499/62499.2.patch

Environment

WordPress: 6.8-alpha-59274-src
PHP: 8.2.25
Server: nginx/1.27.2
Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.25)
Browser: Chrome 131.0.0.0
OS: macOS
Theme: Twenty Twenty-Five

Actual Results

✅ Count is now better positioned. The patch fixes the issue.

Supplemental Artifacts

https://postimg.cc/JyJf8rY8

#10 @rinkalpagdar
2 months ago

Reproduction Report

Description

This report validates whether the issue can be reproduced.

Environment

  • WordPress: 6.8-alpha-59274-src
  • PHP: 8.2.25
  • Server: nginx/1.27.2
  • Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.25)
  • Browser: Chrome 131.0.0.0
  • OS: macOS
  • Theme: Twenty Twenty-Five 1.0
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.0

Actual Results

  1. Error condition does not occur.

Supplemental Artifacts

https://core.trac.wordpress.org/attachment/ticket/62499/themes-count-design.png

#11 @audrasjb
8 weeks ago

  • Keywords commit added; needs-testing removed
  • Owner set to audrasjb
  • Status changed from new to accepted

The PR fixes the issue on my side as well. Self assigning for commit.

#12 @audrasjb
8 weeks ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 59708:

Themes: Improve theme count behavior in the Add Themes screen.

This changeset fixes an UI issue where the theme count in the "Add Themes" screen touches the top border on small screens.

Props sukhendu2002, diliphingarajiya, dilipbheda, ankitkumarshah, dhruvang21, im3dabasia1.
Fixes #62499.

Note: See TracTickets for help on using tickets.