WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#6250 closed defect (bug) (fixed)

Timestamp editing is confusing

Reported by: markjaquith Owned by: markjaquith
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.5
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

  1. The "Edit Timestamp" checkbox is redundant. The clicking of the "Edit" link implies that you want to edit the timestamp.
  2. The "Edit" link functions as a way to hide the date-editing fields -- the text should change to reflect this when the panel is open.
  3. Canceling and hiding the timestamp editing fields should cancel the timestamp edit.
  4. The time interface is confusing with its "@ FIELD FIELD" interface and because 24-hour time is left for the user to figure out

http://img98.imageshack.us/img98/4338/timestampoy0.png

Attachments (2)

better-date-editing.diff (8.6 KB) - added by markjaquith 6 years ago.
7596.diff (611 bytes) - added by stevish 6 years ago.
Fixes the mm typo so that changing minutes triggers edit_time

Download all attachments as: .zip

Change History (14)

comment:1 markjaquith6 years ago

  • Keywords has-patch added
  • Milestone changed from 2.6 to 2.5
  • Owner changed from anonymous to markjaquith
  • Status changed from new to assigned

better-date-editing.diff does the following:

  1. No more "Edit timestamp" checkbox. Hidden form fields track whether or not the date/time has been changed
  2. "Edit" link turns to "Cancel" after being clicked
  3. Clicking "Cancel" link resets the date fields (synced from the hidden ones)
  4. Re-worked the text in front of the date to be more accurate. Future-dated drafts are given "Publish on: DATE" ... future-published posts are given: "Scheduled for: DATE" ... past-published posts are given: "Published on: DATE," and drafts that will be published immediately when the Publish button is pressed just say: "Publish immediately"
  5. Added the "by Username" to the "Last edit" portion, per HC mockup and at Ryan's suggestion.
  6. inserted manual line break before @ HOURS : MINUTES, for better readability
  7. inserted a comma between the day of the month and the year for better readability

comment:2 ryan6 years ago

(In [7338]) Better date editing from MarkJaquith. see #6250

comment:3 ryan6 years ago

Changed the "Last edit..." text to look more like the mockups. I'm not sure how I feel about "Publish immediately". I think a timestamp needs to be there to better indicate the purpose of the edit link.

comment:4 ryan6 years ago

Need the same for pages.

comment:5 fitztrev6 years ago

After r7338, Firebug spotted this error when changing the month of the timestamp: edit_date is not defined

comment:6 markjaquith6 years ago

(In [7339]) Remove reference to edit_date which no longer exists. Props fitzrev. see #6250

comment:7 markjaquith6 years ago

(In [7341]) Bring Edit Page screen up to parity with Edit Post screen WRT timestamps. see #6250

comment:8 markjaquith6 years ago

(In [7342]) Sync "Last edited" on Edit Page screen to that on Edit Post screen. see #6250

comment:9 markjaquith6 years ago

The problem with having a timestamp is that after one minute, the timestamp is out of date, and it implies that hitting "Publish" will publish the post in the past. Clearly the point of having the current timestamp up there is to indicate that it will be published "now." What better way to represent an ever-changing "now" than with a word like "immediately" ?

I just think that if someone is publishing without scheduling, they don't care what the time was when they started editing... that's just cruft that makes them look at the clock to make sure it represents the current time, minus how long they spent editing.

comment:10 stevish6 years ago

Found a typo in the diff file (but I don't have shell access therefore I don't think I can add patches myself... So one of you other spiffy people will have to do it).

In comments.php, the foreach() that was added to see if anything has been changed doesn't check if 'mn' was changed. Instead, it checks 'mm' twice. The second 'mm' simply needs to be changed to 'mn'.

This typo is causing the timestamp not to be edited if you only edit the minute.

stevish6 years ago

Fixes the mm typo so that changing minutes triggers edit_time

comment:11 stevish6 years ago

Alright, Now that it's uploaded, I think I went about this wrong... But regardless, I just uploaded a patch to fix the typo. If I did it very very wrong, and you'd like to yell at me for it (I wouldn't mind), direct your comments to stevish@… so that this article is not bogged down.

comment:12 ryan6 years ago

  • Milestone changed from 2.9 to 2.6
  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.