TypeError in class-wp-plugins-list-table.php due to invalid $time value.

[azora]

A fatal error occurred due to the latest update and is causing problems in the database. Even after I disabled all plugins and installed older wordpress versions, the problem remains due to the cron.

[22-Nov-2024 22:43:55 UTC] PHP Notice:  Function _load_textdomain_just_in_time was called <strong>incorrectly</strong>. Translation loading for the <code>astra</code> domain was triggered too early. This is usually an indicator for some code in the plugin or theme running too early. Translations should be loaded at the <code>init</code> action or later. Please see <a href="https://developer.wordpress.org/advanced-administration/debug/debug-wordpress/">Debugging in WordPress</a> for more information. (This message was added in version 6.7.0.) in /.../wp-includes/functions.php on line 6114
[22-Nov-2024 22:43:55 UTC] PHP Notice:  Function _load_textdomain_just_in_time was called <strong>incorrectly</strong>. Translation loading for the <code>astra</code> domain was triggered too early. This is usually an indicator for some code in the plugin or theme running too early. Translations should be loaded at the <code>init</code> action or later. Please see <a href="https://developer.wordpress.org/advanced-administration/debug/debug-wordpress/">Debugging in WordPress</a> for more information. (This message was added in version 6.7.0.) in /.../wp-includes/functions.php on line 6114

[22-Nov-2024 22:43:55 UTC] PHP Fatal error:  Uncaught TypeError: Unsupported operand types: string + int in /.../wp-admin/includes/class-wp-plugins-list-table.php:189
Stack trace:
#0 /.../wp-admin/plugins.php(553): WP_Plugins_List_Table->prepare_items()
#1 {main}
  thrown in /.../wp-admin/includes/class-wp-plugins-list-table.php on line 189

The error comes from this function:

foreach ( $recently_activated as $key => $time ) {
    if ( $time + WEEK_IN_SECONDS < time() ) {
        unset( $recently_activated[ $key ] );
    }
}

My correction:

foreach ( $recently_activated as $key => $time ) {
    if ( (int) $time + WEEK_IN_SECONDS < time() ) {
        unset( $recently_activated[ $key ] );
    }
}

The problem has been fixed for me.

https://core.trac.wordpress.org/ticket/62542

[umeshsinghin]

Hi @azora, the suggested changes have been implemented.

[deepakrohilla]

@umeshsinghin The PR looks good to me.

@umeshsinghin Good catch!
The PR looks good to me.

[SergeyBiryukov]

In 61481:

Plugins: Remove incorrect entries from the recently_activated option array.

This aims to avoid a fatal error if the array was somehow corrupted and contains non-numeric values.

Follow-up to [8049].

Props umeshsinghin, azora, sabernhardt, deepakrohilla, narenin, SergeyBiryukov.
Fixes #62542.

[SergeyBiryukov]

Hi there, thanks for the ticket!

$time appears to always be an integer in this code in my testing, so the type casting might seem redundant.

I think we can remove any non-integer values from the recently_activated array instead, see [61481].