Duplicate menu-top-first class in admin menu

[kkmuffme]

the "menu-top-first" class is there twice (just open /wp-admin/)

<li class="wp-first-item wp-has-submenu wp-has-current-submenu wp-menu-open menu-top menu-top-first menu-icon-dashboard menu-top-first" id="menu-dashboard">

Same issue also here:

<a href='index.php' class="wp-first-item wp-has-submenu wp-has-current-submenu wp-menu-open menu-top menu-top-first menu-icon-dashboard menu-top-first">

[sabernhardt]

My mistake. You meant the side admin menu.

[karthickmurugan]

Inspect Element screenshot of Dashboard

[karthickmurugan]

Hi @kkmuffme.,

I cannot find the exact issue that you have mentioned. The class you have mentioned is not duplicated. Please check the attached screenshot

[abcd95]

Hey @kkmuffme,

As @karthickmurugan demonstrated, even I couldn't find the duplication of the "menu-top-first" class, neither in the codebase nor after inspecting the admin menu page.

Can you please provide a specific location or screenshot of the page where you have encountered this issue?

Trac ticket: https://core.trac.wordpress.org/ticket/62546

[kkmuffme]

@karthickmurugan it depends on the which menu's are displayed.

Issue arises from ​https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-admin/menu.php#L24 which gets the duplicate class added from ​https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-admin/includes/menu.php#L234 or
​https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-admin/includes/menu.php#L251

Created a PR to fix it

[vishalmori]

Hello @kkmuffme,
I tested the issue and found that the class is added twice when the WooCommerce plugin is activated. When I deactivate or remove WooCommerce, the issue is resolved. Therefore, this is not a WordPress core issue.

Environment with woocommerce

• WordPress: 6.7.1
• PHP: 8.1.2-1ubuntu2.20
• Server: Apache/2.4.52 (Ubuntu)
• Database: mysqli (Server: 8.0.40-0ubuntu0.22.04.1 / Client: mysqlnd 8.1.2-1ubuntu2.20)
• Browser: Chrome 131.0.0.0
• OS: Linux
• Theme: Twenty Twenty-Five 1.0
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.2.0
  • WooCommerce 9.5.1

Result: ✅ Issue occurs (reproduced).

Environment without woocommerce

• WordPress: 6.7.1
• PHP: 8.1.2-1ubuntu2.20
• Server: Apache/2.4.52 (Ubuntu)
• Database: mysqli (Server: 8.0.40-0ubuntu0.22.04.1 / Client: mysqlnd 8.1.2-1ubuntu2.20)
• Browser: Chrome 131.0.0.0
• OS: Linux
• Theme: Twenty Twenty-Five 1.0
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.2.0

Result: ❌ Issue does not occur.

[vishalmori]

When woocommerce is active

[vishalmori]

Whithout woocommerce

[audrasjb]

As per today's bug scrub, it appears this ticket is not directly related to Core. Let's wait for a confirmation though. I'm adding the close keyword in the meantime.

[audrasjb]

I'm closing this ticket as it looks like it's not related to WP Core.Please open a ticket on WooCommerce side.

[JeffPaul]

​https://github.com/woocommerce/woocommerce/issues/56466 was opened porting this over to WooCommerce.

[JeffPaul]

Noting that Woo closed the issue there, so if you have insights for them please comment on ​https://github.com/woocommerce/woocommerce/issues/56466