Make WordPress Core

Opened 2 weeks ago

Last modified 3 days ago

#62550 new defect (bug)

Missing "submit" button - bad accessibility

Reported by: kkmuffme's profile kkmuffme Owned by:
Milestone: 6.8 Priority: normal
Severity: minor Version:
Component: Administration Keywords: has-patch
Focuses: accessibility Cc:

Description (last modified by sabernhardt)

open /wp-admin/

Both of those forms do not have a "submit" but all forms must have a submit for accessibility reasons https://www.w3.org/WAI/WCAG22/Techniques/html/H32

Since the submit button is displayed conditionally, it might make sense to only load it as form conditionally too? (e.g. as div if we do not have anything submittable)

Change History (10)

#1 @sabernhardt
2 weeks ago

  • Description modified (diff)
  • Focuses accessibility added

#2 @sabernhardt
2 weeks ago

  • Description modified (diff)

#3 @rinkalpagdar
2 weeks ago

Hello @kkmuffme
Can you please provide more details or screenshot? So it will be helpful to reproduce the exact issue.
Thanks!

#4 @mayanktripathi32
2 weeks ago

  • Keywords needs-screenshots added

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


6 days ago

#6 @joedolson
6 days ago

  • Milestone changed from Awaiting Review to 6.8

The purpose of a submit button in a form is to request a change of context, and it is certainly valuable there. In the screen options interface, the behavior is immediate when selecting which features are shown on the page, and doesn't generate a change of context. However, this form also doesn't inform the user audibly that the update has taken place, so there's very low confidence in what has happened.

Practically speaking, I'm not sure it would be a benefit to add the submit button when the only fields are the metabox selectors or list table selectors; but we should definitely add a wp.a11y.speak() announcement to confirm that the change has happened.

Regarding the inline comment reply form, I don't see any case where that appears without a submit button, so I'm not sure what you're referring to.

I'm milestoning this for 6.8, but only to add a speak() announcement to the Options checkboxes; I don't think that a submit button would be beneficial here.

This ticket was mentioned in PR #7944 on WordPress/wordpress-develop by @yogeshbhutkar.


5 days ago
#7

  • Keywords has-patch added

### Description
This pull request introduces speak announcements to provide audible confirmation for changes made to checkbox actions within the Screen Options panel.

Trac ticket: https://core.trac.wordpress.org/ticket/62550

#8 @yogeshbhutkar
5 days ago

In response to the recent feedback provided by @joedolson, the speak announcements have been appropriately implemented in the submitted pull request.

Thank you @joedolson for your input.

Last edited 5 days ago by yogeshbhutkar (previous) (diff)

#9 @kkmuffme
3 days ago

Thanks!
That doesn't fix the issue of validity - if we don't have a submit (e.g. bc it's all JS), then this shouldn't be a <form> but a <div>

#10 @kkmuffme
3 days ago

  • Keywords needs-screenshots removed
Note: See TracTickets for help on using tickets.