Make WordPress Core

Opened 3 months ago

Last modified 24 hours ago

#62550 new defect (bug)

Missing "submit" button - bad accessibility

Reported by: kkmuffme's profile kkmuffme Owned by:
Milestone: 6.8 Priority: normal
Severity: minor Version:
Component: Administration Keywords: has-patch needs-testing
Focuses: accessibility Cc:

Description (last modified by sabernhardt)

open /wp-admin/

Both of those forms do not have a "submit" but all forms must have a submit for accessibility reasons https://www.w3.org/WAI/WCAG22/Techniques/html/H32

Since the submit button is displayed conditionally, it might make sense to only load it as form conditionally too? (e.g. as div if we do not have anything submittable)

Change History (19)

#1 @sabernhardt
3 months ago

  • Description modified (diff)
  • Focuses accessibility added

#2 @sabernhardt
3 months ago

  • Description modified (diff)

#3 @rinkalpagdar
3 months ago

Hello @kkmuffme
Can you please provide more details or screenshot? So it will be helpful to reproduce the exact issue.
Thanks!

#4 @mayanktripathi32
3 months ago

  • Keywords needs-screenshots added

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


2 months ago

#6 @joedolson
2 months ago

  • Milestone changed from Awaiting Review to 6.8

The purpose of a submit button in a form is to request a change of context, and it is certainly valuable there. In the screen options interface, the behavior is immediate when selecting which features are shown on the page, and doesn't generate a change of context. However, this form also doesn't inform the user audibly that the update has taken place, so there's very low confidence in what has happened.

Practically speaking, I'm not sure it would be a benefit to add the submit button when the only fields are the metabox selectors or list table selectors; but we should definitely add a wp.a11y.speak() announcement to confirm that the change has happened.

Regarding the inline comment reply form, I don't see any case where that appears without a submit button, so I'm not sure what you're referring to.

I'm milestoning this for 6.8, but only to add a speak() announcement to the Options checkboxes; I don't think that a submit button would be beneficial here.

This ticket was mentioned in PR #7944 on WordPress/wordpress-develop by @yogeshbhutkar.


2 months ago
#7

  • Keywords has-patch added

### Description
This pull request introduces speak announcements to provide audible confirmation for changes made to checkbox actions within the Screen Options panel.

Trac ticket: https://core.trac.wordpress.org/ticket/62550

#8 @yogeshbhutkar
2 months ago

In response to the recent feedback provided by @joedolson, the speak announcements have been appropriately implemented in the submitted pull request.

Thank you @joedolson for your input.

Last edited 2 months ago by yogeshbhutkar (previous) (diff)

#9 @kkmuffme
2 months ago

Thanks!
That doesn't fix the issue of validity - if we don't have a submit (e.g. bc it's all JS), then this shouldn't be a <form> but a <div>

#10 @kkmuffme
2 months ago

  • Keywords needs-screenshots removed

@audrasjb commented on PR #7944:


3 weeks ago
#11

Hi @yogeshbhutkar and thanks for the PR.
I tested you changeset on Playground using the provided link and I wasn't able to show any a11y.speak message when toggling the Welcome Panel for example.

@yogeshbhutkar commented on PR #7944:


3 weeks ago
#12

Hi @audrasjb, I tried testing the Playground link and looks like it's working fine for me. I believe in order to test these, we need to enable the voice over setting from accessibility settings.

https://github.com/user-attachments/assets/15da589f-57ff-4088-8b4f-a8a29f4b487e

@yogeshbhutkar commented on PR #7944:


3 weeks ago
#13

Hi @audrasjb, circling back to check if you were able to reproduce the speak events.

@audrasjb commented on PR #7944:


3 weeks ago
#14

I believe in order to test these, we need to enable the voice over setting from accessibility settings.

Yeah I know, but when looking at the DOM (via the inspector) on Playground, I can't see any change in the a11y.speak elements. I'll give it a new test later today :)

This ticket was mentioned in Slack in #core-test by oglekler. View the logs.


9 days ago

#16 @krupajnanda
9 days ago

  • Keywords needs-testing added

This ticket was discussed during the Test team bug scrub, and we found that it needs more testing to perform.

#17 @codersaiful
2 days ago

  • Keywords needs-screenshots added

I see the #PR, but I'm unable to reproduce the scenario. Could you provide more details along with a screenshot?

#18 @yogeshbhutkar
24 hours ago

This PR adds wp.a11y.speak() announcement to confirm the changes that happen after interacting with the checkboxes present under the Screen Elements within the Dashboard and Posts pages.

To hear the speak events, you'll however need to enable voice over settings from accessibility.

I've attached a screencast demonstrating the working of the PR here: https://github.com/WordPress/wordpress-develop/pull/7944#issuecomment-2609525196

Notice the presence of events stating The checkbox Quick Drafts has been unchecked. when you either check or uncheck the checkbox.

In general, this is how the speak events would be produced: https://www.youtube.com/watch?v=qQI6HqU-zSA&t=20s&ab_channel=SamifromFoxland

#19 @yogeshbhutkar
24 hours ago

  • Keywords needs-screenshots removed
Note: See TracTickets for help on using tickets.