Add PHP 8.4 compat array functions: `array_find`, `array_find_key`, `array_any` and `array_all`

[Soean]

Add polyfill functions for PHP 8.4 array utilities

• Added array_find function to search an array for the first element that passes a given callback.
• Added array_find_key function to search an array for the first key that passes a given callback.
• Added array_any function to check if any element of an array passes a given callback.
• Added array_all function to check if all elements of an array pass a given callback.

• Added array_find function to search an array for the first element that passes a given callback.
• Added array_find_key function to search an array for the first key that passes a given callback.
• Added array_any function to check if any element of an array passes a given callback.
• Added array_all function to check if all elements of an array pass a given callback.

Trac ticket: https://core.trac.wordpress.org/ticket/62558

[TobiasBg]

Related: #62061, #62277
Previously added polyfills: [57337], [52038]

One Inline Documentation request, if I may: There should not be a blank line before the @return, see ​https://developer.wordpress.org/coding-standards/inline-documentation-standards/php/#1-functions-class-methods

[ayeshrajans]

Do we have a guideline on which functions we polyfill, and which we don't?

PHP 8.4 has more new functions, and and the likelihood of functions like mb_*trim functions being useful enough to polyfill is as good as the new array_* functions.

I'm not objecting this ticket in particular, just wanted to put my two cents forward that we probably should follow a guideline (of which I don't know if exists) so we can maintain the polyfills properly.

[desrosj]

Replying to ayeshrajans:

Do we have a guideline on which functions we polyfill, and which we don't?

We don't currently have any official guidance in the handbook. Perhaps that's a good thing to add. If I had to write up that section today, this is what I would list as the criteria used to weigh when evaluating whether to include a PHP language polyfill:

• Polyfill code size
• How self contained is the polyfill? It should serve a single-responsibility unless absolutely necessary (we want to avoid adding entire polyfill classes and libraries as much as possible).
• How many old code patterns does the polyfill replace in favor of consistency?
• Performance improvement compared to these older patterns. Large improvements lend to the polyfill being a strong progressive enhancement that plugin and theme developers can count on being available.
• Does the new function protect against common mistakes? For example, str_contains() guarding against scenarios where if ( strpos( 'This is a haystack', 'This' ) ) is evaluated as falsey.
• Are these old patterns prevalent throughout Core? Would the polyfill help remove a good amount of duplicate code?
• Maintenance burden of adding a polyfill. It should be simple to remove later.
• The range of PHP versions currently supported. For example, if something is added in 8.4, a polyfill would currently allow for supporting the new function in 7 additional PHP versions.

In the case of these functions, it's difficult to find occurrence in Core where this would be useful, but I think it's a reasonable assumption there are a good number of instances where this would be useful. But it will require a more manual effort.

The PR looks good to me, I just approved it. I would love to give the opportunity for @joemcgill and @Mamaduka to weigh in as my fellow Core Tech Leads for 6.8 in case they have any opposing opinions.

[desrosj]

In 59783:

General: Introduce polyfills for new array related functions in PHP 8.4.

PHP 8.4 introduced four new functions to provide a common way to more easily perform common operations on arrays.

• array_find(): ​https://www.php.net/manual/en/function.array-find.php
• array_find_key(): ​https://www.php.net/manual/en/function.array-find-key.php
• array_all(): ​https://www.php.net/manual/en/function.array-all.php
• array_any(): ​https://www.php.net/manual/en/function.array-any.php

These functions are now polyfilled making them available on all supported versions of PHP (currently 7.2+).

Props Soean, swissspidy, TobiasBg, ayeshrajans, mukesh27, joemcgill.
Fixes #62558.

[Mamaduka]

Reasoning makes sense. I use JS versions of these new methods daily, which are very handy.

I think we'll see more usage in the core now that polyfills have been merged.