Wrong warning about _load_textdomain_just_in_time used incorrectly if $theme->__toString()

[DaveFX]

One of my installed plugins has these lines in its initialization function:

<?php
$current_theme = wp_get_theme();

if ('Flatsome' == $current_theme) {
  // Do something
} else {
  // Do a different thing
}

The issue here is that the implicit \_\_toString() call in the theme class ultimately calls

translate("My Child Theme Name","my-theme-name")

which generates a wrong warning about _load_textdomain_just_in_time used incorrectly, saying that the culprit is the theme code, when the backtraces shows this is not the case.

I honestly think this is an issue from WordPress Core, as this _ _toString() call to get the theme name shouldn't ever generate this warning.

[swissspidy]

One of my installed plugins has these lines in its initialization function:

How is this function defined and when is it called? Please share the full code.

This warning is only triggered if you trigger a translation call too early, for example if you are not waiting until init or so.

You should wait until after_setup_theme to call wp_get_theme(). If you do that, then you would not get such a warning.

I honestly think this is an issue from WordPress Core, as this _ _toString() call to get the theme name shouldn't ever generate this warning.

Why not? The WP_Theme::__toString() docblock explicitly says the string will be translated. And if you trigger a translation too early, then you should get a warning.
Changing the __toString() method would be a back compat break.

If you want the untranslated theme name, which for your code example would be desired anyway, use $current_theme->get( 'Name' ) or simply get_stylesheet()

[rinkalpagdar]

Hello @im3dabasia1
Thanks for the feedback. The issue is that a user should be created with an invalid username, such as a dot or blank space. There should be some validation. That's it.

[swissspidy]

@rinkalpagdar maybe it was done by accident, please don't hijack a ticket like that :)

[rinkalpagdar]

Hello @swissspidy
There was some misunderstanding because I had created a ticket with the same number.
I have added a screenshot below.