Make WordPress Core

Opened 7 weeks ago

Closed 5 weeks ago

Last modified 4 weeks ago

#62603 closed enhancement (fixed)

Review the wording used in the theme install checks page

Reported by: afercia's profile afercia Owned by: audrasjb's profile audrasjb
Milestone: 6.8 Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-screenshots has-patch has-testing-info commit
Focuses: ui-copy Cc:

Description

When installing a theme by uploading a zip file, the wording used in some strings may refer to the 'active' theme even though it's not the currrently active theme.

This may be confusing for users and the wording could be improved.

The theme install process may show a page with warnings about some checks such as PHP and WordPress verisions, and also the theme version.

To reproduce:

  • Go to WP admin > Appearance > Add New Thene > Upload Theme.
  • Upload a theme zip.
  • Do not activate the theme.
  • Go again to WP admin > Appearance > Add New Thene > Upload Theme.
  • Upload the same theme zip.
  • During the theme installation process you will get a page that informs 'This theme is already installed.'
  • Observe some strings refer to the theme as 'active' even though it's not the active theme.

Specifically:

  • The header of one of the table header is 'Active'.
  • The button text is: 'Replace active with uploaded'.
  • There's at least one more string that refers to 'active': 'You are uploading an older version of the active theme'.

Attachments (3)

active.png (137.7 KB) - added by afercia 7 weeks ago.
Before-Testing-pullrequest7915.png (78.1 KB) - added by maximemeganck 5 weeks ago.
Before Testing pullrequest 7915
After-Testing-pullrequest7915.png (83.9 KB) - added by maximemeganck 5 weeks ago.
After Testing pullrequest 7915

Download all attachments as: .zip

Change History (16)

@afercia
7 weeks ago

#1 @ankitkumarshah
7 weeks ago

Reproduction Report

Description

This report validates whether the issue can be reproduced.

Environment

  • WordPress: 6.7.1
  • PHP: 8.1.29
  • Server: nginx/1.16.0
  • Database: mysqli (Server: 8.0.16 / Client: mysqlnd 8.1.29)
  • Browser: Chrome 131.0.0.0
  • OS: macOS
  • Theme: Twenty Twenty-Five 1.0
  • MU Plugins: None activated
  • Plugins: Test Reports 1.2.0

Actual Results

  1. ✅ condition occurs (reproduced).

Additional Notes

Hi @afercia,

Thank you for bringing this up. I believe using terms like current or original would be more appropriate than active, as active might lead to some ambiguity.

Supplemental Artifacts

https://utfs.io/f/TnWMEUzoUd852jRt23ysLHOEug5XoIVt4wpi91dJWxrvPeDc

This ticket was mentioned in PR #7915 on WordPress/wordpress-develop by @abcd95.


7 weeks ago
#2

  • Keywords has-patch added

Trac ticket: 62603

This ticket was mentioned in PR #7916 on WordPress/wordpress-develop by @yogeshbhutkar.


7 weeks ago
#3

### Description
This PR updates the terminology on the Theme Installer page from Active to Current, as described in the Trac Ticket below.

Trac ticket: [](https://core.trac.wordpress.org/ticket/62603)

### Screenshots
![Uploading Screenshot 2024-11-29 at 9.24.36 AM.png…]()

#4 @abcd95
7 weeks ago

Hey @afercia, Thanks for reporting this issue.

The current wording referring to themes as "Active" can indeed be misleading when they're installed but not activated. I think the word "Installed" would be a more appropriate word here since "Installed" directly reflects the theme's current state—it's present on the system. This matches WordPress's general terminology, where we talk about "Installed themes" vs. "Available themes."

Using "Installed" maintains consistency with other parts of the WordPress admin where we refer to themes as being in an "installed" state.

I welcome any suggestions if this can be improved further.

#5 @parthvataliya
7 weeks ago

  • Keywords has-testing-info added

#6 @sainathpoojary
7 weeks ago

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://github.com/WordPress/wordpress-develop/pull/7915

Environment

  • WordPress: 6.8-alpha-59274-src
  • PHP: 8.2.26
  • Server: nginx/1.27.3
  • Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.26)
  • Browser: Chrome 131.0.0.0
  • OS: macOS
  • Theme: Twenty Twenty-Five 1.0
  • MU Plugins: None activated
  • Plugins: None activated

Actual Results

  1. ✅ Issue resolved with patch.

Supplemental Artifacts

Before patch:

https://utfs.io/f/PL8E4NiPUWyOlx6JABUFvL3unmS7e6ZWRODwrzf2jyCcBM9A

After patch:

https://utfs.io/f/PL8E4NiPUWyO6cMDfGXILecyvHwBdbisfSAoq2h5TGkQU0C4

#7 @afercia
7 weeks ago

'installed' sounds fine to me, thanks.

#8 @afercia
7 weeks ago

  • Milestone changed from Awaiting Review to 6.8

#9 @audrasjb
6 weeks ago

"Installed" sounds better to me than "Current" since "Current" may lead people to think of this theme as the currently active one as well. Installed sounds clear to me.

#10 @maximemeganck
5 weeks ago

Hello from the contributor day at Whodunit !

Test Report

This report validates that the indicated patch addresses the issue.

Patch tested: REPLACE_WITH_PATCH_URL

Environment

  • OS: macOS
  • Web Server: Nginx
  • PHP: 7.4.29
  • WordPress: 6.8 Alpha
  • Browser: Arc
  • Theme: Twenty Twenty-Five
  • Active Plugins: None

Actual Results

  • ✅ Issue resolved with patch.
  • See the screenshots below

@maximemeganck
5 weeks ago

Before Testing pullrequest 7915

@maximemeganck
5 weeks ago

After Testing pullrequest 7915

#11 @audrasjb
5 weeks ago

  • Keywords commit added
  • Owner set to audrasjb
  • Status changed from new to accepted

Looks good to go, self assigning for commit after our small test and triage during the WDT contributor day.

#12 @audrasjb
5 weeks ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 59513:

Themes: Replace "Active" wording with "Installed" in the theme install checks page.

When reinstalling a theme by uploading a ZIP file, the wording used in some strings referred to the "active" theme even though it's not the currrently active theme. This changeset replaces these strings to refer to the "installed" theme, which is more accurate.

Follow-up to [52610], [52580].

Props afercia, ankitkumarshah, abcd95, yogeshbhutkar, parthvataliya, sainathpoojary, virgar, gaellebesson, nuryko, guillaumeturpin, maximemeganck, sabrineg.
Fixes #62603.
See #54831, #54770

Note: See TracTickets for help on using tickets.