Make WordPress Core

Opened 2 days ago

Closed 2 days ago

#62609 closed defect (bug) (wontfix)

Remove .wp-login-logo class as it is unused

Reported by: im3dabasia1's profile im3dabasia1 Owned by: im3dabasia1's profile im3dabasia1
Milestone: Priority: normal
Severity: normal Version: 6.7.1
Component: Login and Registration Keywords: has-patch has-screenshots close
Focuses: css, coding-standards Cc:

Description

The .wp-login-logo class was introduced in a prior changeset #59138 (6.7) but the corresponding CSS selectors were reverted in a subsequent changeset #59424 (6.7.1). As a result, the class is no longer used in any .css files in the WordPress core. I propose removing this unused class from the HTML markup for cleaner code.

Change History (5)

This ticket was mentioned in PR #7920 on WordPress/wordpress-develop by @im3dabasia1.


2 days ago
#1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/62609

The .wp-login-logo class is no longer used in any CSS files within WordPress Core. This PR removes the unused class from the HTML markup to improve code clarity and maintainability.

#2 @im3dabasia1
2 days ago

  • Keywords has-screenshots added

Sharing a screenshot showing no CSS linked to the .wp-login-logo class: https://i.postimg.cc/Df5RNMqp/Screenshot-2024-11-29-at-3-41-29-PM.png

@mukesh27 commented on PR #7920:


2 days ago
#3

It doesn’t cause any harm, so we can leave it? WDYT @joedolson

#4 @TobiasBg
2 days ago

  • Keywords close added

The class might now be used by people that needed a quick solution to restore broken login logos after the release of WP 6.7 and before the release of WP 6.7.1.
These solutions might break again if the class is removed, which therefore would be a backward-compatibility break.

Due to this, the class should probably stay.

#5 @joedolson
2 days ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from assigned to closed

I think we should leave this in place; both for the same reason that @TobiasBg suggested, but also because I think it's a benefit to have this specific selector available.

I'm going to close this as wontfix; feel free to re-open if you think it needs more discussion.

Note: See TracTickets for help on using tickets.