WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #62619, comment 4


Ignore:
Timestamp:
12/02/2024 09:47:41 PM (7 months ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #62619, comment 4

    initial v1  
    22> As expected, this change impacts some test cases since the security checks previously handled by `wp_kses_post` are now less restrictive
    33
    4 Yea, many of the tests in Tests_Functions_WpAdminNotice won't pass after reverting that change. I wouldn't call these "security" tests. They just confirm how the HTML is restricted in admin notices.
     4Yea, several of the tests in [https://github.com/WordPress/wordpress-develop/blob/trunk/tests/phpunit/tests/functions/wpAdminNotice.php Tests_Functions_WpAdminNotice] won't pass after reverting that change. I wouldn't call these "security" tests. They just confirm how the HTML is restricted in admin notices.
    55
    66> Could you confirm if it’s acceptable to address the failing test cases (primarily removing them) as part of this PR?