Is writable check for fonts folder is misleading/wrong

[zodiac1978]

If no font library is used, the check for folders permissions in Site Health is returning “not writable” for the fonts directory because it does not exist.

I think this is misleading. Maybe it could be created and would be writable then, but it is just not there at the moment.

[zodiac1978]

Site Health check showing the fonts directory as not writable (although there are no permission issues)

[samiamnot]

Introduced with #60719 (version 6.6 would be correct, but does not seem available as an option). #61638 is somewhat related.

[sainathpoojary]

Reproduction Report

Description

This report validates whether the issue can be reproduced.

Environment

• WordPress: 6.8-alpha-59274-src
• PHP: 8.2.26
• Server: nginx/1.27.3
• Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.26)
• Browser: Chrome 131.0.0.0
• OS: macOS
• Theme: Twenty Twenty-Five 1.0
• MU Plugins: None activated
• Plugins: Test Reports 1.2.0

Actual Results

✅ Error condition occurs.

Supplemental Artifacts

This PR enhances the filesystem checks in the Site Health debug data by addressing the following:

#### 1. Existence Check

• Before checking if the fonts directory is writable, it first verifies whether the directory exists.

#### 2. Improved Messaging

• If the fonts directory does not exist, the debug output now reflects this scenario as "Does not exist".
• If the directory exists, it shows whether it is writable or not.

### Changes Made

• Updated the get_wp_filesystem() method in class-wp-debug-data.php.
• Added a directory existence check (file_exists) for the fonts directory (wp_get_font_dir()['basedir']).
• Adjusted the debug data output to handle cases where the fonts directory does not exist.

### Before fix:
Without Font directory

### After fix:

Without Font directory

With Font directory

Trac ticket: #62633

[abcd95]

Test Report

Description

This report validates the indicated patch works as expected.

Environment

• WordPress: 6.7.1
• PHP: 8.1.29
• Server: nginx/1.16.0
• Database: mysqli (Server: 8.0.16 / Client: mysqlnd 8.1.29)
• Browser: Chrome 131.0.0.0
• OS: macOS
• Theme: Twenty Twenty-Five 1.0

Actual Results

✅ Issue resolved with patch.

Supplemental Artifacts

Screenshots

Before: ​https://postimg.cc/cKsy44VW

After: ​https://postimg.cc/GBY8rzwV

[ankitkumarshah]

Test Report

Description

This report validates whether the indicated patch works as expected.

Environment

• WordPress: 6.7.1
• PHP: 8.1.29
• Server: nginx/1.16.0
• Database: mysqli (Server: 8.0.16 / Client: mysqlnd 8.1.29)
• Browser: Chrome 131.0.0.0
• OS: macOS
• Theme: Twenty Twenty-Five 1.0
• MU Plugins: None activated

Actual Results

1. ✅ Issue resolved with patch.

Supplemental Artifacts

Before Patch

After patch

[im3dabasia1]

Reproduction Report

Description

This report validates whether the issue can be reproduced.

Environment

• WordPress: 6.8-alpha-59274-src
• PHP: 8.2.25
• Server: nginx/1.27.2
• Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.25)
• Browser: Chrome 129.0.0.0
• OS: macOS
• Theme: Twenty Twenty-Five 1.0
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.2.0

Actual Results

1. ✅ Error condition occurs (reproduced).

Additional Notes

• Any additional details worth mentioning.

Supplemental Artifacts

[im3dabasia1]

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: ​https://github.com/WordPress/wordpress-develop/pull/7933.diff

Environment

• WordPress: 6.8-alpha-59274-src
• PHP: 8.2.25
• Server: nginx/1.27.2
• Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.25)
• Browser: Chrome 129.0.0.0
• OS: macOS
• Theme: Twenty Twenty-Five 1.0
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.2.0

Actual Results

1. ✅ Issue resolved with patch.

Supplemental Artifacts