Is writable check for fonts folder is misleading/wrong

[zodiac1978]

If no font library is used, the check for folders permissions in Site Health is returning “not writable” for the fonts directory because it does not exist.

I think this is misleading. Maybe it could be created and would be writable then, but it is just not there at the moment.

[zodiac1978]

Site Health check showing the fonts directory as not writable (although there are no permission issues)

[samiamnot]

Introduced with #60719 (version 6.6 would be correct, but does not seem available as an option). #61638 is somewhat related.

[sainathpoojary]

Reproduction Report

Description

This report validates whether the issue can be reproduced.

Environment

• WordPress: 6.8-alpha-59274-src
• PHP: 8.2.26
• Server: nginx/1.27.3
• Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.26)
• Browser: Chrome 131.0.0.0
• OS: macOS
• Theme: Twenty Twenty-Five 1.0
• MU Plugins: None activated
• Plugins: Test Reports 1.2.0

Actual Results

✅ Error condition occurs.

Supplemental Artifacts

This PR enhances the filesystem checks in the Site Health debug data by addressing the following:

#### 1. Existence Check

• Before checking if the fonts directory is writable, it first verifies whether the directory exists.

#### 2. Improved Messaging

• If the fonts directory does not exist, the debug output now reflects this scenario as "Does not exist".
• If the directory exists, it shows whether it is writable or not.

### Changes Made

• Updated the get_wp_filesystem() method in class-wp-debug-data.php.
• Added a directory existence check (file_exists) for the fonts directory (wp_get_font_dir()['basedir']).
• Adjusted the debug data output to handle cases where the fonts directory does not exist.

### Before fix:
Without Font directory

### After fix:

Without Font directory

With Font directory

Trac ticket: #62633

[abcd95]

Test Report

Description

This report validates the indicated patch works as expected.

Environment

• WordPress: 6.7.1
• PHP: 8.1.29
• Server: nginx/1.16.0
• Database: mysqli (Server: 8.0.16 / Client: mysqlnd 8.1.29)
• Browser: Chrome 131.0.0.0
• OS: macOS
• Theme: Twenty Twenty-Five 1.0

Actual Results

✅ Issue resolved with patch.

Supplemental Artifacts

Screenshots

Before: ​https://postimg.cc/cKsy44VW

After: ​https://postimg.cc/GBY8rzwV

[ankitkumarshah]

Test Report

Description

This report validates whether the indicated patch works as expected.

Environment

• WordPress: 6.7.1
• PHP: 8.1.29
• Server: nginx/1.16.0
• Database: mysqli (Server: 8.0.16 / Client: mysqlnd 8.1.29)
• Browser: Chrome 131.0.0.0
• OS: macOS
• Theme: Twenty Twenty-Five 1.0
• MU Plugins: None activated

Actual Results

1. ✅ Issue resolved with patch.

Supplemental Artifacts

Before Patch

After patch

[im3dabasia1]

Reproduction Report

Description

This report validates whether the issue can be reproduced.

Environment

• WordPress: 6.8-alpha-59274-src
• PHP: 8.2.25
• Server: nginx/1.27.2
• Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.25)
• Browser: Chrome 129.0.0.0
• OS: macOS
• Theme: Twenty Twenty-Five 1.0
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.2.0

Actual Results

1. ✅ Error condition occurs (reproduced).

Additional Notes

• Any additional details worth mentioning.

Supplemental Artifacts

[im3dabasia1]

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: ​https://github.com/WordPress/wordpress-develop/pull/7933.diff

Environment

• WordPress: 6.8-alpha-59274-src
• PHP: 8.2.25
• Server: nginx/1.27.2
• Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.25)
• Browser: Chrome 129.0.0.0
• OS: macOS
• Theme: Twenty Twenty-Five 1.0
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.2.0

Actual Results

1. ✅ Issue resolved with patch.

Supplemental Artifacts

[zodiac1978]

Hey @sainathpoojary, thanks for the PR!

Just one thing: $is_fonts_dir_exist sounds a little bit wrong for me. I am not a native speaker, but $is_writable_fonts_dir sounds like an English sentence and $is_fonts_dir_exist does not.

Maybe just $fonts_dir_exists following the common naming convention?

@SergeyBiryukov There was one check failing, but I don't think this is in relation to the patch. Is this a known issue?
​https://github.com/WordPress/wordpress-develop/pull/7933/commits/7f297db89e32fe5e12cca88468c1d549d5855722

[sainathpoojary]

Thanks for the feedback, @zodiac1978! I’ve updated the variable name to $fonts_dir_exists, Also all the checks are now passing. Please take a look whenever you have a moment.

[zodiac1978]

@sainathpoojary It looks like you have changed the wrong line.
$is_fonts_dir_exist should be $fonts_dir_exists

[sainathpoojary]

Thanks for catching that @zodiac1978! I’ve now corrected the variable rename to $fonts_dir_exists. Let me know if there’s anything else that needs adjusting.

[audrasjb]

I tested the PR it it looks great to me.

[audrasjb]

In 59853:

Site Health: Improve fonts directory check.

This changeset enhances the filesystem checks in the Site Health debug data by addressing the following:

• Existence Check: Before checking if the fonts directory is writable, it first verifies whether the directory exists.
• Improved Messaging: If the fonts directory does not exist, the debug output now reflects this scenario as "Does not exist". If the directory exists, it shows whether it is writable or not.

Props zodiac1978, samiamnot, sainathpoojary, abcd95, ankitkumarshah, im3dabasia1.
Fixes #62633.

committed in https://core.trac.wordpress.org/changeset/59853