Make WordPress Core

Opened 3 months ago

Closed 2 months ago

#62635 closed defect (bug) (duplicate)

Twenty Nineteen: Latest Comments block text color differs in editor when adding a background color preset and a text color

Reported by: pitamdey's profile pitamdey Owned by:
Milestone: Priority: normal
Severity: minor Version:
Component: Bundled Theme Keywords: has-patch needs-testing has-testing-info changes-requested
Focuses: Cc:

Description

In the Twenty Nineteen theme, the text color of the Latest Comments block differs between the editor and the frontend when a background color is applied.

Here is the recording :
https://drive.google.com/file/d/1cjTF1M4sHBZYIn5HLIiPTtOlcMoesdEw/view?usp=sharing

Attachments (3)

62635.patch (822 bytes) - added by pitamdey 3 months ago.
Patch for this issue
before-patch.mp4 (557.0 KB) - added by parthvataliya 3 months ago.
after-patch.mp4 (490.3 KB) - added by parthvataliya 3 months ago.

Download all attachments as: .zip

Change History (10)

@pitamdey
3 months ago

Patch for this issue

#1 @mayanktripathi32
3 months ago

  • Keywords needs-testing added
  • Severity changed from normal to minor

#2 @sukhendu2002
3 months ago

  • Keywords has-testing-info added

Reproduction Report

Description

This report validates whether the issue can be reproduced.

Environment

  • WordPress: 6.8-alpha-59274-src
  • PHP: 8.2.26
  • Server: nginx/1.27.3
  • Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.26)
  • Browser: Chrome 131.0.0.0
  • OS: macOS
  • Theme: Twenty Nineteen 3.0
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.0

Actual Results

  1. ✅ Error condition occurs (reproduced).

Supplemental Artifacts

https://utfs.io/f/TTyF6MLuAyHDgSS9Ab6pRlqkhx1L0bWpCmcnstITz2yDaKvi

#3 @sukhendu2002
3 months ago

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/62635/62635.patch

Environment

  • WordPress: 6.8-alpha-59274-src
  • PHP: 8.2.26
  • Server: nginx/1.27.3
  • Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.26)
  • Browser: Chrome 131.0.0.0
  • OS: macOS
  • Theme: Twenty Nineteen 3.0
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.0

Actual Results

  1. ✅ Issue resolved with patch.

Additional Notes

  • ❌ Predefine Theme colors is not working properly

Supplemental Artifacts

https://utfs.io/f/TTyF6MLuAyHDubEgXAdWyK1RlD7zABLOgs0UQ8nPqjTHX5Zx

https://utfs.io/f/TTyF6MLuAyHDmH7n1x5cy0ML1dvzKaDCHngR4TXU9ulNPpbV

Last edited 3 months ago by sukhendu2002 (previous) (diff)

#4 @parthvataliya
3 months ago

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/62635/62635.patch

Environment

  • WordPress: 6.8-alpha-59274-src
  • PHP: 8.2.26
  • Server: nginx/1.27.3
  • Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.26)
  • Browser: Chrome 131.0.0.0
  • OS: Linux
  • Theme: Twenty Nineteen 3.0
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.0

Actual Results

  1. ✅ Issue resolved with patch.

Supplemental Artifacts

Before patch: https://core.trac.wordpress.org/attachment/ticket/62635/before-patch.mp4
After patch: https://core.trac.wordpress.org/attachment/ticket/62635/after-patch.mp4

#5 @rinkalpagdar
3 months ago

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/62635/62635.patch

Environment

  • WordPress: 6.8-alpha-59274-src
  • PHP: 8.2.25
  • Server: nginx/1.27.2
  • Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.25)
  • Browser: Chrome 131.0.0.0
  • OS: macOS
  • Theme: Twenty Nineteen 3.0
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.0

Actual Results

  1. ✅ Issue resolved with patch.

#6 @poena
3 months ago

  • Keywords changes-requested added

I would like to encourage everyone to take the time to research and understand what is causing the problems, and to consider what impact the suggested changes may have. It is sometimes better to ask a few questions more.

Twenty Nineteen has a feature that changes the text color depending on the background color.
If the white color was removed from this CSS; then the text would no longer be accessible.
The color contrast ratio between the background and text would be too low to pass the accessibility requirements.
This change would also affect all paragraphs inside HTML elements with this class, not only the Latest Comments block.

.has-dark-gray-background-color p {
  color: #fff;
}

The text color would also change on live websites, and it would be an unexpected change for the users.

Twenty Nineteen uses SASS. The CSS files are generated from the SCSS files.
If you change the CSS files directly, the changes will be overwritten when the SCSS files are built.
You can find the commands to build the files in the package.json file.

I recommend only submitting the changes to the SCSS files, because otherwise there may be merge conflicts that make it more difficult to test the patches.
Then, the tester can download the patch and re-build the CSS files locally.

#7 @sabernhardt
2 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from new to closed
  • Summary changed from Twenty Nineteen : Latest Comment Block text color differs on frontend and editor on adding background color to Twenty Nineteen: Latest Comments block text color differs in editor when adding a background color preset and a text color

#49931 does not mention the Latest Comments block (yet), but all similar blocks should need the same patch.

Note: See TracTickets for help on using tickets.