Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #62643, comment 3


Ignore:
Timestamp:
12/04/2024 02:47:29 PM (12 months ago)
Author:
grapestain
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #62643, comment 3

    v1 v2  
    1 Well, I'm definitely not suggesting hiding errors, but fatal errors may be still a bit too harsh. I'm just thinking this need to be reconsidered because obviously any decision regarding the translation system was made before PHP v8.0, so there's a chance that assumptions made back then would not hold up any more.
     1Well, I'm definitely not suggesting hiding errors, but fatal errors may be still a bit too harsh. More like calling a `wp_trigger_error()` instead with a warning level.
     2
     3I'm just thinking this need to be reconsidered because obviously any decision regarding the translation system was made before PHP v8.0, so there's a chance that assumptions made back then would not hold up any more.
    24
    35But I get it what you mean, like if a sneaky translator can add a chunk of JavaScript to e.g. trigger an XSS why would WP not trust the translations for correctness? One argument for that is adding an attack vector to a translation cannot happen by accident, but crashing thousands of WP sites by adding an extra placeholder can happen by honest mistake, so they are not the same.