Use WP_Query in wp_get_post_autosave

[spacedmonkey]

Use WP_Query in wp_get_post_autosave and replace the raw database query.

WP_Query is cached and has a number of useful filters.

Trac ticket: https://core.trac.wordpress.org/ticket/62658

Trac ticket: https://core.trac.wordpress.org/ticket/62658

Refactored the function to use WP_Query instead of raw SQL query.

Thanks for your PR! Looks like #7962 was a bit quicker, so let's consolidate the two.

Additional props to @im3dabasia who opened #7965

Trac ticket: https://core.trac.wordpress.org/ticket/62658

This PR adds unit tests for the wp_get_post_autosave() function. The tests cover:

1. Checking if a post has no autosave.
2. Verifying that an autosave is created after a revision.
3. Ensuring autosaves are added for a specific user.

Hey @swissspidy,

I’ve added some unit tests. This is my first time contributing to unit tests, and I included the previous diff in my PR as I wasn’t sure of the best way to write tests for the new diff.

Please, whenever you have a moment, could you check this and provide feedback?

No need to create a new PR for the tests, you can add them to the existing one.

No need to create a new PR for the tests, you can add them to the existing one.

Thanks for your suggestion! I’m not entirely sure how I can push changes directly into someone else’s PR. I’m also unsure if I have write access to the branch for ​this PR, so I’m uncertain about the process for doing that.

When I reviewed other tickets that required unit tests in the past, I saw that a separate patch or PR was raised for those. I followed that approach here, assuming it was the preferred method.

Could you kindly guide me on how to proceed with adding the unit tests to the existing PR? I’d appreciate your help!

@im3dabasia I have added the Test case in #7962

Closing as it incorporate in original PR ​https://github.com/WordPress/wordpress-develop/pull/7962/commits/e96123449010208bc3e185579d6f76faf31ce8e2

[mukesh27]

Move to 6.8 for visibility

[flixos90]

From what I can tell, the PR ​https://github.com/WordPress/wordpress-develop/pull/7962 could use a follow up review. @spacedmonkey Any chance you can take another look? I'm asking since you requested changes previously.

[spacedmonkey]

I have submitted a review.

@narenin take a look pending feedback ​https://github.com/WordPress/wordpress-develop/pull/7962#discussion_r1875403456 from @spacedmonkey

@spacedmonkey I have implemented suggestions, could you please take a look.

Hi @spacedmonkey,

Would we be eligible to receive the Testing badge once this PR is merged? I initially contributed to the tests in the ​PR, which was later merged into this PR. I was wondering if I might still be eligible for the badge.

Nice work @narenin 💯

@spacedmonkey thanks for the feedbacks, I have implemented the suggestions could you please take the look.

@im3dabasia See ​https://make.wordpress.org/test/handbook/test-team-profile-badges/ for that badge and its requirements and how to request it if you meet them.

@spacedmonkey LGTM

[mukesh27]

Mark for commit consideration.

Trac ticket:

[spacedmonkey]

In 59715:

Revisions: Use WP_Query in wp_get_post_autosave.

Replaced the raw SQL query in the wp_get_post_autosave function with a WP_Query call. This change improves code maintainability and replaces the raw SQL query with a cacheable query via WP_Query.

Props narenin, swissspidy, mukesh27, spacedmonkey, im3dabasia1.
Fixes #62658.

Committed in https://core.trac.wordpress.org/changeset/59715