WordPress.org
Get WordPress

Make WordPress Core

Opened 6 months ago

Closed 4 months ago

Last modified 4 months ago

#62674 closed enhancement (fixed)

HTML API: Documentation, signature, and test improvements for 6.8

Reported by: jonsurrell's profile jonsurrell Owned by: gziolo's profile gziolo
Milestone: 6.8 Priority: normal
Severity: normal Version: trunk
Component: HTML API Keywords: has-patch
Focuses: Cc:

Description

This ticket collects general work on the HTML API targeting 6.8 around documentation, function signatures, and testing.

Change History (7)

This ticket was mentioned in ​PR #7984 on ​WordPress/wordpress-develop by ​@jonsurrell.
6 months ago #1

  • Keywords has-patch added

Remove nullable from the WP_HTML_Processor::get_breadcrumbs() return function signature and PHPDoc types.

The return type of breadcrumbs has not be nullable since [58713 HTML API: Simplify breadcrumb accounting.]

Trac ticket: https://core.trac.wordpress.org/ticket/62674

#2 @gziolo
6 months ago

  • Owner set to gziolo
  • Resolution set to fixed
  • Status changed from new to closed

In 59503:

HTML API: Remove nullable from get_breadcrumbs return type

Follow-up [58713]
Props jonsurrell, westonruter, gziolo.
Fixes #62674.

#3 @gziolo
6 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

This ticket was mentioned in ​Slack in #core by audrasjb. ​View the logs.
4 months ago

#6 @audrasjb
4 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

@gziolo it looks like this ticket was reopened by mistake, so I'm closing it as fixed.

#7 @audrasjb
4 months ago

If needed, feel free to reopen it and add it back to the milestone :)

Note: See TracTickets for help on using tickets.