Opened 5 weeks ago
Closed 4 weeks ago
#62688 closed defect (bug) (wontfix)
Twenty Seventeen: Comments block having space issue for the comment title.
Reported by: | viralsampat | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | close |
Focuses: | css | Cc: |
Description
Hello Team,
I have checked "Comment" block and found that there is some spacing or floating issue into the comment title on the front-end.
I think that it should be same like editor side.
Here, I have attached its screenshots.
Attachments (5)
Change History (9)
@
5 weeks ago
I have checked above mentioned issue and I have resolved it and added patch. Also, I have attached screenshot after resolved this issue.
#2
@
5 weeks ago
- Keywords needs-testing removed
Hey @viralsampat,
Thank you for providing the patch. I have tested it on the front-end, and the changes successfully resolve the spacing and floating issues with the comment title. The updated styling now matches the editor side as expected. Additionally, I tested it on Twenty Twenty-Five and other recent themes to ensure there are no regressions, and everything is working as expected.
#3
@
5 weeks ago
- Keywords close added; dev-feedback removed
- Summary changed from Twenty seventeen theme: The comment block having space issue for the comment title. to Twenty Seventeen: Comments block having space issue for the comment title.
- Version 6.7.1 deleted
I want to close this for the same reason as #55744.
The Comments block does not belong within the post/page content, especially with a theme that already has a comments template such as Twenty Seventeen. The block creates duplicate IDs, which is a bigger problem than broken styles. A bad appearance can help discourage someone from using the block.
[38866] set the styles on #comments
, and ID selectors should only affect one element. However, the Comments block adds a comments
ID to its heading (without the ability to customize it in the sidebar). The #comments
selector probably could be switched to .comments-area
in both stylesheets, but I prefer keeping the broken appearance.
#4
@
4 weeks ago
- Milestone Awaiting Review deleted
- Resolution set to wontfix
- Status changed from new to closed
I agree with the approach to close this raised by @sabernhardt and I am going to go ahead and do that. Thank you for reporting and also thank you for collaboration on this. As a note, closing doesn't mean we can't reconsider but there has been a very clear reason given to close for now.
Back-end: