RSS Import Doesn't Properly Strip CDATA Tags

[sweetdeal]

When importing an RSS feed that uses the <description> tag as opposed to <content:encoded>, I noticed that WP's RSS import doesn't strip the CDATA tags as it does for the <content:encoded>.

=========Code Lines (83-87)===============

if (!$post_content) {
// This is for feeds that put content in description
preg_match('|<description>(.*?)</description>|is', $post, $post_content);
$post_content = $wpdb->escape($this->unhtmlentities(trim($post_content[1])));
}

=====================================

I tweaked the code to solve the problem (see below)

==========Tweaked Code===============

if (!$post_content) {
// This is for feeds that put content in description
preg_match('|<description>(.*?)</description>|is', $post, $post_content);
$post_content = str_replace(array ('<![CDATA[', ']]>'), '',$wpdb->escape($this->unhtmlentities(trim($post_content[1]))));
}

======================================

I'd be happy to submit a patch, except I'm not quite that savvy yet. It would be great it someone could incorporate it. Thanks.

[sweetdeal]

tweaked rss.php (import) file

[sweetdeal]

Just an update -- I became savvy a few seconds after writing this and uploaded the tweaked rss.php file.

[Viper007Bond]

.diff file of sweetdeal's rss.php modifications

[Viper007Bond]

I'm not for or against this patch, I merely made a diff of the original vs. sweetdeal's copy as that's the preferred patch type.

[sweetdeal]

Thanks Viper007. :)

[Nazgul]

Resetting the milestone to 2.6.

Fixes first go into the current development release and if they're deemed important/critical enough will be backported for maintenance releases.

[Denis-de-Bernardy]

imo, better adding the CDATA stuff into the regexp and make it optional material, e.g.:

|<description>(?:<\[CDATA\[)?(.*?)(?:\]\]>)?</description>|is

[Denis-de-Bernardy]

forgot the ! in the above regex, too.

[solarissmoke]

I think the entire RSS importer needs an overhaul - it should stop parsing XML using regexes and switch to simplexml like the Wordpress importer ( #5460 ). I'm happy to spend some time on this, if there is traction?

[nacin]

I'm game for that.

[solarissmoke]

Cool. I'll work on it and ping you once it's ready. There are a few other tickets related to RSS import which I'll try and deal with as well.

[Viper007Bond]

It'll be nice to ditch all of this PHP4 code in favor of PHP5 sexiness.

[solarissmoke]

Right, here is an overhauled rss-importer. It has similar structure to wordpress-importer. Also addresses #7061 and #8982. Will probably need a bit of testing as the parser is from scratch.

[duck_]

Looks like you accidentally left in some testing code, the false &&:

if ( false &&extension_loaded( 'simplexml' ) ) {

[solarissmoke]

Whoops, yes! I'll replace it in a sec.

[solarissmoke]

Should also fix #9678 if there is indeed a bug there

[Viper007Bond]

Unless I'm mistaken, the WordPress.org milestone is for things affecting the actual WordPress.org website. This ticket is about WordPress the software, not WordPress the website.

[SergeyBiryukov]

"Future Release" only applies to core, and importers are no longer a part of the core.

A special component is WordPress.org. In this milestone, we manage tickets for core plugins such as the importers (under the Plugins or Import components), current and former default themes (Bundled Theme component), and the WordPress.org site (component of the same name).

​http://make.wordpress.org/core/handbook/trac/