WordPress.org
Get WordPress

Make WordPress Core

Opened 4 weeks ago

Closed 2 weeks ago

Last modified 2 weeks ago

#62725 closed enhancement (fixed)

Performance tests improvements for 6.8

Reported by: swissspidy's profile swissspidy Owned by: swissspidy's profile swissspidy
Milestone: 6.8 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch has-unit-tests
Focuses: performance Cc:

Description

This is a follow-up to [58097], which added Multisite support to the local environment, and a follow-up to [59524], which added tests for the new TT5 theme.

Based on these changes, the core performance team discussed some ideas to improve the performance tests over at ​https://github.com/WordPress/performance/issues/1735

Mainly:

  • Run tests on Multisite
  • Run tests on a single post page in addition to just the homepage
  • Improve cache flushes / resets between iterations
  • Send TT5 results to the current dashboard at codevital.run
    • Note: The dashboard will need to be updated to make things more digestible

Change History (5)

This ticket was mentioned in ​PR #6515 on ​WordPress/wordpress-develop by ​@swissspidy.
4 weeks ago #1

  • Keywords has-patch has-unit-tests added

What this PR does:

  • Run tests against Multisite, now that the local Docker environment supports it (as of r58097)
  • Run tests on a single post page in addition to just the homepage
  • Try to improve cache flushes / resets between iterations
  • Try to improve workflow names
  • Make workflow job summaries more readable by using <details>
  • ~Collect information about object cache hits & misses, flushing cache between runs~

Trac ticket: https://core.trac.wordpress.org/ticket/62725

​@mukesh27 commented on ​PR #6515:
4 weeks ago #2

In ​https://github.com/WordPress/wordpress-develop/actions/runs/12413679906/job/34656106232?pr=6515#step:25:50, it downloads the Firefox browser. Do we actually need that? Additionally, there are warnings during the build of Playwright. Could these warnings indicate an issue on their side? If so, it might be worth opening a ticket in their repository.

​@swissspidy commented on ​PR #6515:
4 weeks ago #3

We don‘t need Firefox and in the step before we actually only install Chromium. But this download comes from wp-scripts, so this would need an enhancement ticket in Gutenberg.

Looks like these warnings are for missing audio and video codecs, nothing we‘d need for the tests.

#4 @swissspidy
2 weeks ago

  • Owner set to swissspidy
  • Resolution set to fixed
  • Status changed from assigned to closed

In 59577:

Build/Test Tools: Expand performance tests setup.

Run tests against Multisite (possible since [58097]) and on single post pages. Also improve cache flushes/resets between iterations.

Props swissspidy, flixos90, desrosj, mukesh27.
Fixes #62725.

Note: See TracTickets for help on using tickets.