WordPress.org
Get WordPress

Make WordPress Core

Opened 7 months ago

Closed 7 months ago

Last modified 7 months ago

#62732 closed enhancement (fixed)

Split up "upload"

Reported by: timse201's profile timse201 Owned by: audrasjb's profile audrasjb
Milestone: 6.8 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch commit
Focuses: ui Cc:

Description

Upload can be used as a noun or verb. Currently we have only 1 string to translate. It should be split up. We did it in the past and marked them as buttons, verbs and nouns etc.

props go to @wpgerd for the report

Change History (6)

This ticket was mentioned in ​PR #8033 on ​WordPress/wordpress-develop by ​@timse201.
7 months ago #1

  • Keywords has-patch added

Upload can be used as a noun or verb. Currently we have only 1 string to translate. It should be split up. We did it in the past and marked them as buttons, verbs and nouns etc.

props go to ​@wpgerd for the report

#2 @audrasjb
7 months ago

  • Focuses ui added
  • Milestone changed from Awaiting Review to 6.8
  • Owner set to audrasjb
  • Status changed from new to reviewing
  • Version trunk deleted

Thanks for the ticket and the PR,
I'm moving this for 6.8 consideration.

#3 @timse201
7 months ago

thank you

#4 @audrasjb
7 months ago

  • Keywords commit added
  • Status changed from reviewing to accepted

Alright the patch looks good to me. I searched for other occurrences and I didn't find any.

#5 @audrasjb
7 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 59554:

I18n: Add translator context for various occurrences of "upload".

This changeset adds a noun or verb context to the various occurrences of "upload" in the admin, to make it easier for translators to differenciate these strings depending on the context.

Props timse201, wpgerd.
Fixes #62732.

Note: See TracTickets for help on using tickets.