PHPcs Fixes in `class-ftp.php`

[viralsampat]

Hello Team,

I have checked wp-admin & wp-includes folders and found few PHPcs fixes.

• No space before closing parenthesis is prohibited
• Line indented incorrectly; expected at least 1 tabs, found 0

I have applied a patch which will fix this issue.

Thanks,

[EDIT: the related changes are related to `wp-admin/includes/class-ftp.php`, see comment #2]

[viralsampat]

I have checked above mentioned issue and I have resolved it and added patch.

[audrasjb]

Hello and thank you for opening this ticket, however ID3 is an external library so the related files should be modified on the related upstream repository. Also, we don't usually make much WPCS changes on deprecated.php since these functions are, well, deprecated :)

I'm renaming this ticket and description to only mention class-ftp.php.

(and please note that the ticket should reflect which changes are proposed and where, otherwise we would end up with a ton of ticket labelled as "PHPCS fixes in Core" 🙂).

[viralsampat]

Hello @audrasjb

Thank you so much for your feedback.

I will make sure and now onwards I will reflect which changes are proposed and where, So we can understand easily.

Thanks,

[desrosj]

Could you update your patch to remove the changes to the ID3 library and the deprecated file? Since the code in that file is deprecated, we typically try not to update the code there unless absolutely necessary (PHP compatibility, security updates, etc.) as there is very little to no benefit.

In the class-ftp.php file, you've formatted the first if condition in {} but not the others. If we're going to make this change, we'll want to update all of them at the same time.

Just to share context because I keep having to dig around to find the history when changes are suggested to class-ftp.php. The PemFTP library is an upstream library, but is considered abandoned with the version contained in WordPress being the most up to date canonical source (see ticket:47751#comment:1).

Fixes: https://core.trac.wordpress.org/ticket/62750

[shailu25]

Created New ​PR.

Included all mentioned Changes in above comment.

[desrosj]

In 59846:

Coding Standards: Properly space and indent ! defined() checks.

Props viralsampat shailu25, audrasjb.
Fixes #62750.