Make WordPress Core

Opened 6 weeks ago

Closed 4 weeks ago

#62751 closed defect (bug) (reported-upstream)

PHPCS Need to fix on src/wp-includes/Requests/src/Cookie.php

Reported by: umeshsinghin's profile umeshsinghin Owned by:
Milestone: Priority: normal
Severity: normal Version: 6.7.1
Component: External Libraries Keywords: has-patch close
Focuses: coding-standards Cc:

Description

I found a PHPCS issue in src/wp-includes/Requests/src/Cookie.php

  1. No space after opening parenthesis is prohibited
  2. No space before closing parenthesis is prohibited
  3. Expected 1 spaces after opening parenthesis; 0 found
  4. Use Yoda Condition checks, you must.

Change History (4)

#2 @SergeyBiryukov
6 weeks ago

  • Component changed from General to External Libraries
  • Focuses coding-standards added
  • Keywords close added

Hi there, welcome to WordPress Trac! Thanks for the ticket.

Please note that Requests is an external library, which does not have to follow the WordPress coding standards and should not be patched directly in WordPress core. Any suggested changes would need to be submitted to the upstream GitHub repository.

@mukesh27 commented on PR #8059:


5 weeks ago
#3

See comment on ticket: https://core.trac.wordpress.org/ticket/62751#comment:2

Please note that Requests is an external library, which does not have to follow the WordPress coding standards and should not be patched directly in WordPress core. Any suggested changes would need to be submitted to the upstream GitHub repository.

#4 @desrosj
4 weeks ago

  • Milestone Awaiting Review deleted
  • Resolution set to reported-upstream
  • Status changed from new to closed

I'm going to close this out. If someone reports this upstream, please provide an issue/PR link for reference.

Note: See TracTickets for help on using tickets.