Make WordPress Core

Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#62768 closed defect (bug) (invalid)

The doc block does not mention $options, even though it is part of the method signature.

Reported by: albatross10's profile albatross10 Owned by:
Milestone: Priority: normal
Severity: minor Version: trunk
Component: General Keywords:
Focuses: docs Cc:

Description

The constructor in https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/SimplePie/src/Cache/Redis.php#L86-L94 has a docblock. The docblock does not mention $options, even though it is part of the method signature.

It mentions $type which is not a part of the function signature.

Change History (5)

#1 @pratiklondhe
3 months ago

Hi @albatross10,

Thank you for raising the ticket. Upon investigation, it seems the change originates from an external library, SimplePie, merged into the core,

Here are some references for context:

Core changeset: https://core.trac.wordpress.org/changeset/59141
Pull request in the SimplePie GitHub repository that introduced the change: https://github.com/simplepie/simplepie/pull/742

Last edited 3 months ago by pratiklondhe (previous) (diff)

#3 @albatross10
3 months ago

Hey @pratiklondhe

Thanks for the information.
I believe we need to get the latest code from https://github.com/simplepie/simplepie and and that should resolve the issue

Last edited 3 months ago by albatross10 (previous) (diff)

#4 @albatross10
3 months ago

  • Resolution set to invalid
  • Status changed from new to closed

The Redis Class is deprecated so we would not be needing this for now.

#5 @SergeyBiryukov
3 months ago

  • Milestone Awaiting Review deleted
Note: See TracTickets for help on using tickets.