Make WordPress Core

Opened 17 months ago

Closed 3 months ago

#62773 closed defect (bug) (fixed)

Twenty Twenty: Pullquote Block Letter Case Setting Applies Only to Description in Editor, Not Cite

Reported by: paragjethva's profile paragjethva Owned by: joedolson's profile joedolson
Milestone: 7.0 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch commit
Focuses: css Cc:

Description

The Pullquote block in the Twenty Twenty theme has an issue with the Letter Case setting:

In the editor, the Letter Case setting is only applied to the description (quote text) but not to the cite (citation/attribution).
On the frontend, the Letter Case setting works correctly and is applied to both the description and cite.

Attachments (5)

twenty-twenty-theme.webm (3.6 MB) - added by paragjethva 17 months ago.
62773.patch (1.2 KB) - added by hiteshtalpada 17 months ago.
2020-Pullquote-citation-letter-case-with-patch.png (51.2 KB) - added by sabernhardt 4 months ago.
Pullquote blocks in the editor with patch: one block has default styling, the other has uppercase text
62773-before-patch.png (62.2 KB) - added by shailu25 3 months ago.
Before Patch
62773-after-patch.png (62.2 KB) - added by shailu25 3 months ago.
After Patch

Change History (23)

#1 @poena
17 months ago

  • Component changed from Themes to Bundled Theme

#2 @hiteshtalpada
17 months ago

  • Component changed from Bundled Theme to Themes
  • Keywords has-patch added; needs-patch removed

The issue can be resolved by adding or updating the editor-specific styles in the theme to ensure the cite element inherits the Letter Case setting.

#3 follow-up: @mukesh27
17 months ago

  • Component changed from Themes to Bundled Theme
  • Keywords needs-patch added; has-patch removed

@hiteshtalpada The patch 62773.patch seems wrong. isn't it?

#4 in reply to: ↑ 3 @hiteshtalpada
17 months ago

Replying to mukesh27:

@hiteshtalpada The patch 62773.patch seems wrong. isn't it?

@mukesh27, Can you please tell me what I'm doing wrong? I'm create diff using git diff command.

Thanks

#5 @sukhendu2002
16 months ago

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/62773/62773.patch

Environment

  • WordPress: 6.8-alpha-59274-src
  • PHP: 8.2.27
  • Server: nginx/1.27.3
  • Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.27)
  • Browser: Chrome 131.0.0.0
  • OS: macOS
  • Theme: Twenty Twenty 2.8
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.0

Actual Results

  1. ✅ Issue resolved with patch. Pullquote block letter case is working fine in both in editor and frontend.

#6 @hiteshtalpada
16 months ago

@sukhendu2002 Thank you for validating the patch. Your efforts are greatly appreciated!

#7 @poena
16 months ago

Hi
@hiteshtalpada It looks like there is something wrong with the patch because it says that it is changing the separator block on line 890, but the separator is on line 630.
Of course, the separator should be untouched.

I am not sure what may have gone wrong: double check that you are creating the patch on the latest WordPress trunk.

#8 @dhruvang21
16 months ago

@poena, I agree with your observation that the CSS mentioned in the patch is not present in the latest trunk branch. Additionally, I was unable to reproduce this issue in the latest pull.

#9 @dhruvang21
16 months ago

Reproduction Report

Description

This report validates whether the issue can be reproduced.

Environment

  • WordPress: 6.8-alpha-59274-src
  • PHP: 8.2.22
  • Server: nginx/1.27.0
  • Database: mysqli (Server: 8.0.39 / Client: mysqlnd 8.2.22)
  • Browser: Chrome 128.0.0.0
  • OS: Linux
  • Theme: Twenty Twenty 2.8
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.0

Actual Results

❌ I am not able to reproduce this issue.

Supplemental Artifacts

https://www.awesomescreenshot.com/video/35704758?key=b6093ae59a9ab3f236f246af9f1e1d5f

Last edited 16 months ago by dhruvang21 (previous) (diff)

@sabernhardt
4 months ago

Pullquote blocks in the editor with patch: one block has default styling, the other has uppercase text

#10 @sabernhardt
4 months ago

  • Keywords has-patch close 2nd-opinion added; needs-patch removed
  • Milestone changed from Awaiting Review to 7.0

GB11610 started to deprecate the Pullquote block for WordPress 7.0, so it likely is not worth updating Twenty Twenty's editor styles for the block at this time. However, the patch is a small edit to the citation styles, and it worked for me with both default Pullquote styles and the uppercase setting. I'll set the milestone to make a decision whether to commit this patch or to close the ticket with no change at all.

Since WordPress 5.8 stopped adding block-library/theme.css in the editor, text-transform: none has been unnecessary, but setting it to inherit could work in older versions too.

Test Report

Description

This report validates that the indicated patch works as expected.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/62773/62773.patch

Environment

  • WordPress: 7.0-alpha-61215-src (r61418)
  • PHP: 7.4.33
  • Server: Apache/2.4.62 (Win64) PHP/7.4.33 mod_fcgid/2.3.10-dev
  • Database: mysqli (Server: 9.1.0 / Client: mysqlnd 7.4.33)
  • Browser: Firefox 146.0
  • OS: Windows 11
  • Theme: Twenty Twenty 3.0
  • Plugins:
    • Gutenberg 22.3.0

Actual Results

  1. ✅ Issue resolved with patch.

#11 @ugyensupport
4 months ago

Twenty Twenty: Pullquote Block Letter Case Setting Applies Only to Description in Editor, Not Cite

Description

The Pullquote block in the Twenty Twenty theme has an issue with the Letter Case setting:

In the editor, the Letter Case setting is only applied to the description (quote text) but not to the cite (citation/attribution).
On the frontend, the Letter Case setting works correctly and is applied to both the description and cite.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/62773/62773.patch

Environment

  • WordPress: 6.9
  • PHP: 8.5.0
  • Server: Apache/2.4.65 (Unix) mod_wsgi/5.0.2 Python/3.10 mod_fastcgi/mod_fastcgi-SNAP-0910052141 OpenSSL/1.1.1w
  • Database: mysqli (Server: 5.7.44 / Client: mysqlnd 8.5.0)
  • Browser: Chrome 143.0.0.0
  • OS: macOS
  • Theme: Twenty Twenty 3.0
  • MU Plugins:
    • Elementor Safe Mode 1.0.0
  • Plugins:
    • Test Reports 1.2.1
    • WordPress Beta Tester 4.0.0

Actual Results

  1. ✅ Issue resolved with patch.
Last edited 4 months ago by ugyensupport (previous) (diff)

#12 @darshitrajyaguru97
4 months ago

Test Repost for https://core.trac.wordpress.org/attachment/ticket/62773/62773.patch

Description:
==========
The Pullquote block in the Twenty Twenty theme had an inconsistency where the Letter Case setting applied only to the quote text in the editor, but not to the citation.
This caused a mismatch between the editor and frontend behavior. The issue has been resolved, and the Letter Case setting now applies consistently to both the quote and the citation in the editor.

Environment:
===========
PHP: 8.5.0
WordPress: 6.9
Browser: Chrome
Theme: Twenty Twenty
MU Plugin: Elementor Safe Mode 1.0.0

✅Patch is working very well.

#13 @sabernhardt
3 months ago

  • Keywords close 2nd-opinion removed

GB75122 restored the Pullquote block.

#14 @shailu25
3 months ago

Test Report

This Report Validates that the indicated patch address the issue.✅

Patch Tested: https://core.trac.wordpress.org/attachment/ticket/62773/62773.patch

Environment:

WordPress - 6.9.1
OS - Windows
Browser - Chrome
Theme: Twenty Twenty
PHP - 8.2.27
Plugin - None

Actual Results:

  • Issue Resolved with Patch ✅

Supplemental Artifacts

  • Attached

@shailu25
3 months ago

Before Patch

@shailu25
3 months ago

After Patch

#15 @r1k0
3 months ago

Patch Testing Report

Patch Tested: https://core.trac.wordpress.org/attachment/ticket/62773/62773.patch

Environment

  • WordPress: 7.0-beta1-61709-src
  • PHP: 8.2.29
  • Server: nginx/1.29.5
  • Database: mysqli (Server: 8.4.8 / Client: mysqlnd 8.2.29)
  • Browser: Chrome 145.0.0.0
  • OS: Windows 10/11
  • Theme: Twenty Twenty 3.0
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.1

Steps taken

  1. In a post/page, add a pullquote block.
  2. Add a quote and a citation, change the block Letter Case to uppercase.
  3. Observe the changes.
  4. ✅ Patch is solving the problem

Expected result

  • Both the quote and citation should change to uppercase lettering.

Additional Notes

  • None

Screenshots/Screencast with results

  • Screenshot before:

https://i.ibb.co/x8Bb2cGb/pullquote-before.png

  • Screenshot after:

https://i.ibb.co/g2zRJFh/pullquote-after.png

#16 @sabernhardt
3 months ago

  • Keywords commit added

#17 @joedolson
3 months ago

  • Owner set to joedolson
  • Status changed from assigned to accepted

#18 @joedolson
3 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 61743:

Twenty Twenty: Fix Pullquote block letter case setting.

Prevent the Twenty Twenty theme styles from overriding the Pullquote block's letter case settings.

Props paragjethva, hiteshtalpada, shailu25, poena, mukesh27, sukhendu2002, dhruvang21, ugyensupport, darshitrajyaguru97, sabernhardt, r1k0, joedolson.
Fixes #62773.

Note: See TracTickets for help on using tickets.