Make WordPress Core

Opened 5 weeks ago

Last modified 3 weeks ago

#62773 assigned defect (bug)

Twenty Twenty: Pullquote Block Letter Case Setting Applies Only to Description in Editor, Not Cite

Reported by: paragjethva's profile paragjethva Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: needs-patch
Focuses: css Cc:

Description

The Pullquote block in the Twenty Twenty theme has an issue with the Letter Case setting:

In the editor, the Letter Case setting is only applied to the description (quote text) but not to the cite (citation/attribution).
On the frontend, the Letter Case setting works correctly and is applied to both the description and cite.

Attachments (2)

twenty-twenty-theme.webm (3.6 MB) - added by paragjethva 5 weeks ago.
62773.patch (1.2 KB) - added by hiteshtalpada 5 weeks ago.

Change History (11)

@hiteshtalpada
5 weeks ago

#1 @poena
5 weeks ago

  • Component changed from Themes to Bundled Theme

#2 @hiteshtalpada
5 weeks ago

  • Component changed from Bundled Theme to Themes
  • Keywords has-patch added; needs-patch removed

The issue can be resolved by adding or updating the editor-specific styles in the theme to ensure the cite element inherits the Letter Case setting.

#3 follow-up: @mukesh27
5 weeks ago

  • Component changed from Themes to Bundled Theme
  • Keywords needs-patch added; has-patch removed

@hiteshtalpada The patch 62773.patch seems wrong. isn't it?

#4 in reply to: ↑ 3 @hiteshtalpada
5 weeks ago

Replying to mukesh27:

@hiteshtalpada The patch 62773.patch seems wrong. isn't it?

@mukesh27, Can you please tell me what I'm doing wrong? I'm create diff using git diff command.

Thanks

#5 @sukhendu2002
5 weeks ago

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/62773/62773.patch

Environment

  • WordPress: 6.8-alpha-59274-src
  • PHP: 8.2.27
  • Server: nginx/1.27.3
  • Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.27)
  • Browser: Chrome 131.0.0.0
  • OS: macOS
  • Theme: Twenty Twenty 2.8
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.0

Actual Results

  1. ✅ Issue resolved with patch. Pullquote block letter case is working fine in both in editor and frontend.

#6 @hiteshtalpada
5 weeks ago

@sukhendu2002 Thank you for validating the patch. Your efforts are greatly appreciated!

#7 @poena
5 weeks ago

Hi
@hiteshtalpada It looks like there is something wrong with the patch because it says that it is changing the separator block on line 890, but the separator is on line 630.
Of course, the separator should be untouched.

I am not sure what may have gone wrong: double check that you are creating the patch on the latest WordPress trunk.

#8 @dhruvang21
3 weeks ago

@poena, I agree with your observation that the CSS mentioned in the patch is not present in the latest trunk branch. Additionally, I was unable to reproduce this issue in the latest pull.

#9 @dhruvang21
3 weeks ago

Reproduction Report

Description

This report validates whether the issue can be reproduced.

Environment

  • WordPress: 6.8-alpha-59274-src
  • PHP: 8.2.22
  • Server: nginx/1.27.0
  • Database: mysqli (Server: 8.0.39 / Client: mysqlnd 8.2.22)
  • Browser: Chrome 128.0.0.0
  • OS: Linux
  • Theme: Twenty Twenty 2.8
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.0

Actual Results

❌ I am not able to reproduce this issue.

Supplemental Artifacts

https://www.awesomescreenshot.com/video/35704758?key=b6093ae59a9ab3f236f246af9f1e1d5f

Last edited 3 weeks ago by dhruvang21 (previous) (diff)
Note: See TracTickets for help on using tickets.