Opened 14 months ago
Closed 4 months ago
#62775 closed enhancement (invalid)
line length should generally not exceed 80 characters, and the hard limit is 120 characters.
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Priority: | normal | |
| Severity: | minor | Version: | 6.6 |
| Component: | Interactivity API | Keywords: | dev-feedback needs-patch 2nd-opinion |
| Focuses: | coding-standards | Cc: |
Description (last modified by )
wp-includes/interactivity-api/class-wp-interactivity-api.php Line 418
Line length should not more than 120 characters as coding guidelines.
Change History (2)
#1
@
12 months ago
- Description modified (diff)
- Focuses coding-standards added
- Keywords 2nd-opinion added
- Type changed from defect (bug) to enhancement
- Version changed from 6.7 to 6.6
#2
@
4 months ago
- Milestone Awaiting Review deleted
- Resolution set to invalid
- Status changed from new to closed
There's not significant value to be gained by making this change.
WordPress has a policy on code refactoring and I don't believe this meets the requirements.
Note: See
TracTickets for help on using
tickets.
Hi and thanks for the ticket!
The line length limit should apply to DocBlocks, not lines with translatable strings.
Splitting the
$messageline into multiple lines might be an improvement, however.Or the message could go inside
_doing_it_wrong()to avoid creating a$messagevariable.If changing line 418 is valuable, then splitting lines 537 and 564 could be worthwhile too.