Fix update_attached_file return type comment

[arnoutblueshell]

The current return type comment of update_attached_file is inaccurate. It only has the correct return type when the post meta is deleted. But doesn't take into consideration when the post meta is updated.

Proposed new comment:

/**
 * Updates attachment file path based on attachment ID.
 *
 * Used to update the file path of the attachment, which uses post meta name
 * '_wp_attached_file' to store the path of the attachment.
 *
 * @since 2.1.0
 *
 * @param int    $attachment_id Attachment ID.
 * @param string $file          File path for the attachment.
 * @return int|bool Meta ID if the key didn't exist, true on success,
 *                  false on failure or if the value passed to the function
 *                  is the same as the one that is already in the database.
 */
function update_attached_file( $attachment_id, $file ) {

[karthickmurugan]

Patch file with updated comments

[karthickmurugan]

@arnoutblueshell - Thank you creating this issue. I have created a patch file for updating the comments in the function update_attached_file.

[SergeyBiryukov]

In 59602:

Docs: Correct @return value for update_attached_file().

Follow-up to [4612], [21967], [24490], [47611], [48214].

Props arnoutblueshell, karthickmurugan, SergeyBiryukov.
Fixes #62803.