Trying to access array offset on false in /{PATH}/wp-includes/class-wp-recovery-mode-email-service.php on line 367

[afwebdev]

In wp-includes/class-wp-recovery-mode-email-service.php on line 344, is this:

$plugin = $this->get_plugin( $extension );

however WP_Recovery_Mode_Email_Service::get_plugin() can return false, and when that happens the check null !== $plugin on line 363 passes, but then

$debug['plugin']

on line 364 causes the following error:

PHP Warning:  Trying to access array offset on false in /{PATH}/wp-includes/class-wp-recovery-mode-email-service.php on line 367

The solution is to change line 363 to:

if ( is_array( $plugin ) ) {

Trac ticket: 62816

[sainathpoojary]

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: ​https://github.com/WordPress/wordpress-develop/pull/8141

Environment

• WordPress: 6.8-alpha-59274-src
• PHP: 8.2.27
• Server: nginx/1.27.3
• Database: mysqli (Server: 8.4.3 / Client: mysqlnd 8.2.27)
• Browser: Chrome 132.0.0.0
• OS: macOS
• Theme: Twenty Twenty-Four 1.3
• MU Plugins: None activated
• Plugins: Test Reports 1.2.0

Actual Results

✅ Issue resolved with patch.

Supplemental Artifacts

Before Fix:

After Fix: No Warnings

Hi @himanshupathak95,
I’ve tested the PR and here are the results:

### Before Applying the Patch:
The following warning was encountered:
### Before patch:

### After Applying the Patch:

• Checked out to this PR.
• Outcome: The warnings previously observed are no longer present.

Trac ticket: https://core.trac.wordpress.org/ticket/62816

Closing as #8143 is better approach. Feel free to reopen.

[SergeyBiryukov]

In 61448:

Site Health: Check plugin data in WP_Recovery_Mode_Email_Service::get_debug().

This resolves a PHP warning when preparing debug information for the fatal error protection email if ::get_plugin() returned false due to the failing plugin not being found.

Follow-up to [46273].

Props mukesh27, afwebdev, abcd95, sainathpoojary, ankitkumarshah, SergeyBiryukov.
Fixes #62816.

[sabernhardt]

#57152 was marked as a duplicate.