Walker_Nav_Menu duplicated queries introduced by get_privacy_policy_url() call

[arzola]

The start_el() method in Walker_Nav_Menu currently calls get_privacy_policy_url() for every menu item when building menus. This results in redundant queries, particularly for menus with many items.

if ( get_privacy_policy_url() === $menu_item->url ) {
        $atts['rel'] = empty( $atts['rel'] ) ? 'privacy-policy' : $atts['rel'] . ' privacy-policy';
}

get_privacy_policy_url should be memoized and called outside of this scope because it will be triggered for each element when building menus, resulting in tons of duplicated queries

The start_el() method in Walker_Nav_Menu currently calls get_privacy_policy_url() for every menu item when building menus. This results in redundant queries, particularly for menus with many items. This patch memoizes the get_privacy_policy_url() result, improving performance while maintaining existing functionality.

I just fixed the tests behaviour, they were running well in isolation but failing when running all

[arzola]

Ok false alarm I need to work the tests changes because they run well on isolation but when the entire tests suite is running they fail, not sure what I'm doing wrong

[arzola]

Updated PR and solution

Thank you @westonruter I'm kinda lost what's the next step hahaha, should I open a SVN PR?, not sure what to do

Ah, the next step is for a committer to take your code and commit to SVN. So your work here is done!

[westonruter]

@arzola FYI: There's no harm in attaching the patch to a ticket, but in reality it's easier to just use the PR directly. So you can skip having to do that in the future. Thanks!

[arzola]

Gotcha, thank you very much for your guidance

[arzola]

Do I need to do something here? like rebasing my branch or something like that? :)

[westonruter]

@arzola No, just apply the suggestions that @mukesh27 made to your PR.

[westonruter]

In 59674:

Menus: Improve performance by calling get_privacy_policy_url() once per Walker_Nav_Menu instance rather than for every nav menu item.

The start_el() method in Walker_Nav_Menu was calling get_privacy_policy_url() for every menu item when building menus. This resulted in redundant queries, particularly for menus with many items. This obtains the get_privacy_policy_url() value in the constructor for reuse in the start_el() method to improve performance.

Redundant code to construct the privacy policy page is also refactored into the set_up() method during tests.

Props arzola, swissspidy, westonruter, mukesh27.
Fixes #62818.

[westonruter]

@arzola Congrats on your first commit props! Thank you for your contribution, not only opening a ticket but also providing the patch to fix it.