Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #62824, comment 5


Ignore:
Timestamp:
01/20/2025 09:22:00 AM (12 months ago)
Author:
apermo
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #62824, comment 5

    initial v1  
    5757So I ended up in the `elseif()` but sent an empty string to `$wp_locale->get_month( substr( $m, 4, 2 ) )` resulting the warning and `$my_month` to be empty, and thus the whole function to return false.
    5858
    59 Returning January by default would be wrong in my eyes, and as I wanted to point out, not necessary, as `single_month_title()` already accounts for it. I understand your point, and I also think this function as a whole could use an overhaul, but the one backwards compatible way me and my colleague found was to add the sanitization as we did in the PR.
     59Returning January by default would be wrong in my eyes, and as I wanted to point out, not necessary, as `single_month_title()` already accounts for it. I understand your point, and I also think this function as a whole could use an overhaul, but the one backwards compatible way me and my colleague (Props to @xate for digging into it with me) found was to add the sanitization as we did in the PR.