Rename the "setted_transient" action to "set_transient".

[peterwilsoncc]

To quote the Merriam-Webster dictionary's page for the ​definition for setted:

The word you've entered isn't in the dictionary.

The correct work in the context of the action is "set", so I propose renaming the action to correct the misspelling.

This will also introduce consistency with the action name set_transient_{$transient}.

The incorrectly spelt action is ​used in some popular plugins, the two highest installations with 200K+ active installs, so that may be a blocker due to the amount of log entries it will create. It will not be a back-compat break as it would be covered by a do_action_deprecated() call.

---

Edit: setted_site_transient ought to be renamed too as part of this, see comment #3 -- @peterwilsoncc

Trac ticket: https://core.trac.wordpress.org/ticket/62849

[peterwilsoncc]

It was pointed out to me (props @johnbillion) that site transients also contain a miss-spelling, setted_site_transient -- that action should be renamed too.

@sukhendu2002, are you able to push a commit to your PR renaming that too?

I've put this ticket on the 6.8 milestone for consideration.

[sukhendu2002]

Replying to peterwilsoncc:

It was pointed out to me (props @johnbillion) that site transients also contain a miss-spelling, setted_site_transient -- that action should be renamed too.

@sukhendu2002, are you able to push a commit to your PR renaming that too?

I've put this ticket on the 6.8 milestone for consideration.

Thanks for pointing that out! I've added a commit to rename setted_site_transient as well.

[peterwilsoncc]

In 59735:

Options/Meta APIs: Rename setted_(site_)_transient to set_....

Deprecate the actions setted_transient and setted_site_transient in favour of set_transient and set_site_transient respectively.

This serves two purposes, the name is consistent with the transient specific actions set_(site_)_transient_{$transient}, and to make the names grammatically correct.

Props sukhendu2002, swissspidy, johnbillion, peterwilsoncc.
Fixes #62849.