WordPress.org
Get WordPress

Make WordPress Core

Changes between Version 6 and Version 10 of Ticket #62861


Ignore:
Timestamp:
02/20/2025 08:33:14 PM (4 months ago)
Author:
joedolson
Comment:

The PR tests fine; but I'm bothered by the fact that there's no distinction between the script img and the style image for sighted users now. The title attribute only provided assistance for some use cases, but it was *something*.

If we added CSS generated content on the placeholder wrapper or override the background image on .mce-object we might be able to improve this. But I think being able to see that the replacement is for a style or a script tag is necessary.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #62861

    • Property Keywords has-patch added

  • Ticket #62861 – Description

    v6 v10  
    77- [https://github.com/WordPress/wordpress-develop/blob/0f2334da8111913a2a78c5000f27f791bb405f0f/src/js/_enqueues/vendor/tinymce/plugins/wordpress/plugin.js#L142-L151 Style and script tags] have redundant `title` attributes, matching their `alt` text (like `alt="<style>" title="<style>"`). However, the tooltip is the only way to distinguish these two placeholders visually (unless it's worth replacing the transparent GIF with something like a [https://gist.github.com/sabernhardt/8804da31aed02f0c535306bdb2749446 text-based SVG]).
    88
    9 Additional `title` attributes are in other (external) TinyMCE-related scripts. If someone would like to edit and/or replace any of these scripts, please open a separate ticket (for each).
     9Additional `title` attributes are in other (external) TinyMCE-related scripts:
    1010
    1111- The [https://github.com/WordPress/wordpress-develop/blob/61b7b9713ef6a71126c3739a929ce604762de1bf/src/js/_enqueues/vendor/tinymce/plugins/charmap/plugin.js#L1141 character map plugin], which is designed for mouse users, has two title attributes for each character. The script [https://github.com/WordPress/wordpress-develop/blob/61b7b9713ef6a71126c3739a929ce604762de1bf/src/js/_enqueues/vendor/tinymce/plugins/charmap/plugin.js#L1186 uses the `td` title later] for the larger preview on the side. Switching each 'button' div's title to an ARIA label might be a //small// improvement. (Note that the [https://github.com/tinymce/tinymce/blob/6d4d3b8fc862253bc756fdaca60254251fa45277/modules/tinymce/src/themes/silver/main/ts/ui/dialog/Collection.ts#L68 latest charmap plugin] does not have titles anymore.)