WordPress.org
Get WordPress

Make WordPress Core

Changes between Version 3 and Version 6 of Ticket #62861


Ignore:
Timestamp:
02/04/2025 04:28:44 PM (4 months ago)
Author:
sabernhardt
Comment:

As discussed in today's bug scrub, this ticket should focus on only the wordpress/plugin.js placeholder images. Any revision or replacement for the external plugins could have its own ticket.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #62861

    • Property Owner set to joedolson
    • Property Status changed from new to accepted
    • Property Type changed from enhancement to defect (bug)
    • Property Milestone changed from Awaiting Review to 6.8

  • Ticket #62861 – Description

    v3 v6  
    77- [https://github.com/WordPress/wordpress-develop/blob/0f2334da8111913a2a78c5000f27f791bb405f0f/src/js/_enqueues/vendor/tinymce/plugins/wordpress/plugin.js#L142-L151 Style and script tags] have redundant `title` attributes, matching their `alt` text (like `alt="<style>" title="<style>"`). However, the tooltip is the only way to distinguish these two placeholders visually (unless it's worth replacing the transparent GIF with something like a [https://gist.github.com/sabernhardt/8804da31aed02f0c535306bdb2749446 text-based SVG]).
    88
    9 Additional `title` attributes are in other (external) TinyMCE-related scripts:
     9Additional `title` attributes are in other (external) TinyMCE-related scripts. If someone would like to edit and/or replace any of these scripts, please open a separate ticket (for each).
    1010
    1111- The [https://github.com/WordPress/wordpress-develop/blob/61b7b9713ef6a71126c3739a929ce604762de1bf/src/js/_enqueues/vendor/tinymce/plugins/charmap/plugin.js#L1141 character map plugin], which is designed for mouse users, has two title attributes for each character. The script [https://github.com/WordPress/wordpress-develop/blob/61b7b9713ef6a71126c3739a929ce604762de1bf/src/js/_enqueues/vendor/tinymce/plugins/charmap/plugin.js#L1186 uses the `td` title later] for the larger preview on the side. Switching each 'button' div's title to an ARIA label might be a //small// improvement. (Note that the [https://github.com/tinymce/tinymce/blob/6d4d3b8fc862253bc756fdaca60254251fa45277/modules/tinymce/src/themes/silver/main/ts/ui/dialog/Collection.ts#L68 latest charmap plugin] does not have titles anymore.)