Make WordPress Core

Opened 13 months ago

Last modified 5 months ago

#62866 new enhancement

Adjust background alternate row on post and page tables

Reported by: karmatosed's profile karmatosed Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch changes-requested
Focuses: ui, accessibility, css Cc:

Description (last modified by karmatosed)

Now that the lighter background has been added, the background on hover for the post and pages table could be adjusted also. Whilst the lightest color grey is #f0f0f0 in Storybook, dataViews have the table hover at #f8f8f8. I would recommend we use that and attach that as option.

What this does is reduce number of grays which are getting out of control a bit again.

Attachments (2)

SCR-20250125-skll.png (271.5 KB) - added by karmatosed 13 months ago.
SCR-20250125-srhw.png (264.1 KB) - added by karmatosed 13 months ago.

Download all attachments as: .zip

Change History (22)

This ticket was mentioned in PR #8194 on WordPress/wordpress-develop by @karmatosed.


13 months ago
#1

  • Keywords has-patch added; needs-patch removed

This changes the background color to be consistent with the one used on hover in dataViews.
What this does is reduce number of grays which are getting out of control a bit again.

Trac ticket: https://core.trac.wordpress.org/ticket/62866.

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request.
See GitHub Pull Requests for Code Review in the Core Handbook for more details.

#2 @karmatosed
13 months ago

  • Description modified (diff)

#3 @karmatosed
13 months ago

I am uploading the existing stripe alt to show how small the change is but how beneficial it is in reducing yet more differences.

@audrasjb commented on PR #8194:


13 months ago
#4

Thanks for the PR. Looks good to me 👍

Maybe we can also use #f8f8f8 on the following selectors, in dashboard.css:

  • #activity-widget #the-comment-list .comment-item
  • #future-posts li:nth-child(odd), #published-posts li:nth-child(odd)
  • .community-events ul

That would cover the following elements:
https://github.com/user-attachments/assets/61725eb1-e57e-4146-a1d2-b2e1534553f2

#5 @poena
13 months ago

What are the current and new color contrast ratios between the background color and the different text color?s Since the text color did not change.

Version 0, edited 13 months ago by poena (next)

#6 @audrasjb
13 months ago

@poena it's better than before since the odd rows background color is a bit lighter than before: now we have 6.89:1 for normal text and 4.86:1 for blue links.

#7 @poena
13 months ago

Thank you @audrasjb

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


12 months ago

@karmatosed commented on PR #8194:


12 months ago
#9

@audrasjb I like idea of that, let me see about working on those.

This ticket was mentioned in Slack in #accessibility by audrasjb. View the logs.


12 months ago

#11 follow-up: @joedolson
12 months ago

I think we need to work on adapting the core color palette (https://make.wordpress.org/core/2021/02/23/standardization-of-wp-admin-colors-in-wordpress-5-7/) so that we shift to the new palette consistently.

E.g., if dataviews are using #f8f8f8, the closest in core colors is #f6f7f7, and we should make those agree.

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


12 months ago

#13 in reply to: ↑ 11 @paupaupau555
12 months ago

Totally agree, we ought to have a systematic approach with the least amount effort in order to update in a clean way, having color #f6f7f7 still works as the contrast ratio still reaches the AA rank (not the AAA one but I think that's ok).

Replying to joedolson:

I think we need to work on adapting the core color palette (https://make.wordpress.org/core/2021/02/23/standardization-of-wp-admin-colors-in-wordpress-5-7/) so that we shift to the new palette consistently.

E.g., if dataviews are using #f8f8f8, the closest in core colors is #f6f7f7, and we should make those agree.

This ticket was mentioned in Slack in #design by paupaupau555. View the logs.


12 months ago

#15 @karmatosed
12 months ago

  • Milestone changed from 6.8 to Future Release

Due to the time and views expressed, I am going to for now move this out of this cycle. We can take out time and should with this.

#16 @audrasjb
12 months ago

  • Milestone changed from Future Release to 6.9

Moving to 6.9.

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


11 months ago

#18 @jorbin
6 months ago

  • Keywords changes-requested added; needs-design-feedback removed

The current patch uses #f8f8f8, but it seems like there is consensus around #f6f7f7 instead, so this should get updated and retested.

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


5 months ago

#20 @joedolson
5 months ago

  • Milestone changed from 6.9 to Future Release

This ticket is only relevant if #62831 moves forward, so I'm going to remove it from the milestone for now. If that progresses, this can be moved back in.

Note: See TracTickets for help on using tickets.