Make WordPress Core

Opened 7 weeks ago

Closed 2 weeks ago

#62874 closed defect (bug) (reported-upstream)

core/site-title block adds aria-current to the blog page when it is not the front page

Reported by: bschneidewind's profile bschneidewind Owned by: joedolson's profile joedolson
Milestone: Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: accessibility Cc:

Description

If you set a page as the front page of the site and a separate page for the blog posts page, the site title has an aria-current attribute that will show up on the homepage and also shows up on the page selected for the posts.

It should only show on the front page of the site for the site title.

Change History (7)

This ticket was mentioned in PR #8199 on WordPress/wordpress-develop by bschneidewind.


7 weeks ago
#1

  • Keywords has-patch added

This updates the core/site-title block and the aria-current attribute. This should only be applied to the front page and prevents the aria-current being applied if a user has a separate front page from the posts page. (the posts page should not have an aria-current attribute applied to site title in these instances)

Trac ticket: https://core.trac.wordpress.org/ticket/62874

#2 @joedolson
7 weeks ago

  • Milestone changed from Awaiting Review to 6.8
  • Owner set to joedolson
  • Status changed from new to accepted

Thanks for noting this!

#3 @hbhalodia
7 weeks ago

Hi @joedolson @bschneidewind, Not sure, but this should be fixed/reported upstream to Gutenberg Repo? As this is block level change and should be done here - https://github.com/WordPress/gutenberg/blob/2abe6faaad28bcd73e3548dc5fdff98d0fb15062/packages/block-library/src/site-title/index.php#L34, So when GB merges to core it would reflect the change.

Thank You,

#4 @bschneidewind
7 weeks ago

Thank you @hbhalodia - added the PR over there: https://github.com/WordPress/gutenberg/pull/68909

Should this ticket and the PR in wordpress-develop be closed at this point?

#5 @hbhalodia
7 weeks ago

Hi @bschneidewind, Let's wait for the response from @joedolson. Then we can close this out.

Thank You,

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


2 weeks ago

#7 @joedolson
2 weeks ago

  • Milestone 6.8 deleted
  • Resolution set to reported-upstream
  • Status changed from accepted to closed

Closing this as reported-upstream; I'll get the Gutenberg PR reviewed soon!

Note: See TracTickets for help on using tickets.