WordPress.org
Get WordPress

Make WordPress Core

Opened 20 months ago

Closed 20 months ago

#62875 closed defect (bug) (fixed)

Document global $wp_local_package in wp-includes/l10n.php file.

Reported by: upadalavipul Owned by: audrasjb
Priority: normal Milestone: 6.8
Component: I18N Version:
Severity: normal Keywords: has-patch commit
Cc: Focuses: docs, coding-standards

Description

I have reviewed the below file code and found that we are using a global $wp_local_package variable. but they do not mention it in the function comment. So I think we need to improve the function comment code.

Files:

trunk/wp-includes/l10n.php

Attachments (2)

62875.patch​ (764 bytes ) - added by upadalavipul 20 months ago.
patch Added.
62875-updated.patch​ (501 bytes ) - added by dhruvang21 20 months ago.
Updated patch

Download all attachments as: .zip

Change History (5)

@upadalavipul
20 months ago

patch Added.

#1 @mukesh27
20 months ago

  • Component General → I18N
  • Keywords needs-refresh added
  • Milestone Awaiting Review → 6.8
  • Version trunk

Hi there!

Thanks for the ticket and patch.

The patch need updates.

* @global string $pagenow          The filename of the current screen.
* @global string $wp_local_package Locale code of the package.

@dhruvang21
20 months ago

Updated patch

#2 @audrasjb
20 months ago

  • Keywords has-patch commit added; needs-refresh removed
  • Owner set to audrasjb
  • Status new → assigned

#3 @audrasjb
20 months ago

  • Resolution → fixed
  • Status assigned → closed

In 59719:

Coding Standards: Add missing global variable in determine_locale() docblock.

Props upadalavipul, mukesh27, dhruvang21.
Fixes #62875.

Note: See TracTickets for help on using tickets.