Editor: Update packages for 6.8

[Mamaduka]

Update the packages worked on in the Gutenberg repo for WordPress 6.8.

A list of known issues:

• ​https://github.com/WordPress/gutenberg/pull/68964

Trac ticket: https://core.trac.wordpress.org/ticket/62887

I've not been involved in these syncs in the past, but was under the impression that we were attempting to move away from shipping these kinds of features under the experimental… prefix.

@joemcgill, that only applies to JS API. The block.json is a configuration file that can't have private APIs, hence the __experimental prefixes. They're and will be backward compatible.

Thanks for clarifying! Do we have any documentation or best practice for why and when to use those prefixes for block.json features? If they are intended to be backward compatible, should we be looking to remove these prefixes?

These aren't new configuration values; they just got enabled for those blocks. When those features are stable, we usually create iteration issues like #64314 and stabilize the keys.

I don't recall any official docs, but it is probably worth documenting.

Updated packages to fix private API errors breaking the Site Editor (​https://github.com/WordPress/gutenberg/pull/68964). It should be working correctly now.

Remaining issues:

• I noticed the "Go to the Dashboard" buttons don't work in the Site Editor. It requires changes to ​block editor settings from #7903. I can cherry-pick them in this PR to unblock merging.
• Some JavaScript CI tests fail due to this warning - Warning: The build/wp-includes/js/dist/data.js file must not contain a sourceMappingURL. Use --force to continue. Does anyone have experience fixing it?

## Screeenshot

It looks like wp-polyfill has been reintroduced as a dependency, which causes the test_wp_add_inline_script_before_after_concat_with_core_dependency unit test to fail. It was initially removed via https://core.trac.wordpress.org/ticket/60962.

@swissspidy, any suggestions on how to approach this?

Hmm good question, I wonder what caused this.

Last time this topic came up was in ​https://github.com/WordPress/gutenberg/issues/66552 and ​https://github.com/WordPress/gutenberg/pull/67230

A quick test here shows that wp-polyfill is now suddenly a dependency of wp-i18n, hence this unit test is failing with the new diff.

I thought with ​https://github.com/WordPress/gutenberg/pull/65292 / ​https://github.com/WordPress/gutenberg/pull/65582 the wp-polyfill dependency should only be added when needed.

Tinkering with the Gutenberg package build process I see that the i18n package now tries to load these two polyfills for iterator helpers (which are currently not supported by Safari) in create-i18n.js:

import "core-js/modules/esnext.iterator.constructor.js";
import "core-js/modules/esnext.iterator.for-each.js";

And that's why ultimately the wp-polyfill dependency is added.

create-i18n.js uses new Set() and Set.forEach(), so that's why. But those are supported in Safari, so adding the iterator polyfills is incorrect.

I wonder if we should do something like ​https://github.com/WordPress/gutenberg/pull/67230 but for Iterator. That would solve this issue. cc @sgomes

Related: it can't hurt to update Babel & core-js to the latest versions in the Gutenberg repo, as this will affect polyfills too.

The reason why polyfills are being added unnecessarily is due to fundamental limitations in core-js, the JS polyfill library that we use to make wp-polyfill, and which is used by Babel as well. In a nutshell, it's monolithic where it comes to objects like Set, and assumes that if a Set object is present anywhere, it's going to need all its methods, and therefore all the internal dependencies it uses to polyfill them.

This was likely caused by a core-js update that added new functionality, perhaps ​https://github.com/WordPress/gutenberg/pull/67708?

To follow up on the above, the aforementioned Gutenberg PR updated core-js to version 3.39, which according to ​the project changelog added the Iterator functionality, so we have our smoking gun.

@gziolo: Would it be worth it to replicate the unit test that's failing here (test_wp_add_inline_script_before_after_concat_with_core_dependency) at the Gutenberg level, so that we catch these situations in the Gutenberg repo, before they make their way to Core?

Thanks, @swissspidy, @sgomes.

So, for now, would the proposed resolution be something similar to ​https://github.com/WordPress/gutenberg/pull/67230?

In that case I would say so, yes.

Adding a unit test or CI check for this stuff would be nice for sure.

Here's the PR to fix this problem - ​https://github.com/WordPress/gutenberg/pull/69070.

Would it be worth it to replicate the unit test that's failing here (test_wp_add_inline_script_before_after_concat_with_core_dependency) at the Gutenberg level, so that we catch these situations in the Gutenberg repo, before they make their way to Core?

Sure, that makes perfect sense. It looks like @Mamaduka added some test coverage in ​https://github.com/WordPress/gutenberg/pull/69070 that will help to catch similar regressions.

All outstanding issues for this PR are resolved now. We're good to commit if we decide to do so.

[joemcgill]

In 59775:

Editor: Update packages for 6.8 pre-Betas.

Syncs @wordpress/* packages to the 'latest' npm tag.

Props mamaduka, joemcgill, youknowriad, swissspidy, sergiomdgomes, gziolo.
See #62887.

[joemcgill]

In 59776:

Editor: Add query-total block files.

This is a follow-up to [59775] to add new files that were missed in the original commit.

See #62887.

[joemcgill]

In 59777:

Editor: Add remaining query block file.

This is a follow-up to [59776] and [59775] to add yet another file that was missed in the original commit.

See #62887.

Committed (clumsily) to trunk in:

• https://core.trac.wordpress.org/changeset/59775
• https://core.trac.wordpress.org/changeset/59776
• https://core.trac.wordpress.org/changeset/59777

[!NOTE]
Just a "draft" PR to streamline the process. It includes changes for Gutenberg 20.3.
The last full change will happen tomorrow after Gutenberg 20.4 RC and packages are released.

Trac ticket: https://core.trac.wordpress.org/ticket/62887

[!NOTE]
Just a "draft" PR to streamline the process. It includes changes for Gutenberg 20.3.
The last full change will happen tomorrow after Gutenberg 20.4 RC and packages are released.

Trac ticket: https://core.trac.wordpress.org/ticket/62887

The last full sync. Latest package releases, including Gutenberg 20.4. It should be ready to commit.

[joemcgill]

In 59906:

Editor: Update packages for 6.8 Beta 1.

Syncs @wordpress/* packages to the 'latest' npm tag.

Props mamaduka, joemcgill, desrosj.
See #62887.

Committed via https://core.trac.wordpress.org/changeset/59906.

PR Syncs packages from Gutenberg ahead of Beta 2. Contains the following PRs:

• ​https://github.com/WordPress/gutenberg/pull/69428
• ​https://github.com/WordPress/gutenberg/pull/68909
• ​https://github.com/WordPress/gutenberg/pull/69436
• ​https://github.com/WordPress/gutenberg/pull/69394
• ​https://github.com/WordPress/gutenberg/pull/69413
• ​https://github.com/WordPress/gutenberg/pull/69299
• ​https://github.com/WordPress/gutenberg/pull/69479
• ​https://github.com/WordPress/gutenberg/pull/69417
• ​https://github.com/WordPress/gutenberg/pull/69377
• ​https://github.com/WordPress/gutenberg/pull/69500
• ​https://github.com/WordPress/gutenberg/pull/69506
• ​https://github.com/WordPress/gutenberg/pull/69473
• ​https://github.com/WordPress/gutenberg/pull/69508

Trac ticket: https://core.trac.wordpress.org/ticket/62887

[joemcgill]

In 59961:

Editor: Update packages for 6.8 Beta 2.

Syncs @wordpress/* packages to the 'latest' npm tag.

Props mamaduka, desrosj, joemcgill.
See #62887.

https://core.trac.wordpress.org/changeset/59961

PR Syncs packages from Gutenberg ahead of Beta 3. Contains the following PRs:

• ​https://github.com/WordPress/gutenberg/pull/69516
• ​https://github.com/WordPress/gutenberg/pull/69522
• ​https://github.com/WordPress/gutenberg/pull/69542
• ​https://github.com/WordPress/gutenberg/pull/69537
• ​https://github.com/WordPress/gutenberg/pull/69448
• ​https://github.com/WordPress/gutenberg/pull/69536

Trac ticket: https://core.trac.wordpress.org/ticket/62887

[joemcgill]

In 60036:

Editor: Update packages for 6.8 Beta 3.

Syncs @wordpress/* packages to the 'wp-6.8' npm tag.

Props mamaduka.
See #62887.

PR Syncs packages from Gutenberg ahead of Beta 3. Contains the following PRs:

• ​https://github.com/WordPress/gutenberg/pull/69629
• ​https://github.com/WordPress/gutenberg/pull/69620
• ​https://github.com/WordPress/gutenberg/pull/69520
• ​https://github.com/WordPress/gutenberg/pull/69651
• ​https://github.com/WordPress/gutenberg/pull/69661
• ​https://github.com/WordPress/gutenberg/pull/69666

Trac ticket: https://core.trac.wordpress.org/ticket/62887

[joemcgill]

In 60078:

Editor: Update packages for 6.8 RC 1.

Syncs @wordpress/* packages to the 'wp-6.8' npm tag.

Props mamaduka, audrasjb.
See #62887.

[joemcgill]

Let's keep this tracking ticket rolling for RCs

PR Syncs packages from Gutenberg ahead of RC 2. Contains the following PRs:

• ​https://github.com/WordPress/gutenberg/pull/69716
• ​https://github.com/WordPress/gutenberg/pull/69744
• ​https://github.com/WordPress/gutenberg/pull/69778
• ​https://github.com/WordPress/gutenberg/pull/69781
• ​https://github.com/WordPress/gutenberg/pull/69753

Trac ticket: https://core.trac.wordpress.org/ticket/62887

[audrasjb]

Committer sign-off: PR8628 is good to ship before RC2.

[audrasjb]

In 60114:

Editor: Update packages for 6.8 RC 2.

Syncs @wordpress/* packages to the 'wp-6.8' npm tag.

Props mamaduka.
See #62887.

Committed in https://core.trac.wordpress.org/changeset/60114

[joemcgill]

@audrasjb [60114] looks good for backporting.

[audrasjb]

In 60115:

Editor: Update packages for 6.8 RC 2.

Syncs @wordpress/* packages to the 'wp-6.8' npm tag.

Reviewed by joemcgill.
Merges [60114] to the 6.8 branch.
Props mamaduka.
See #62887.

This includes the corresponding package updates for 6.8 RC4, should it be deemed necessary.

Bugs addressed: ​https://github.com/WordPress/gutenberg/pull/69860

Trac ticket: Core-62887.

[desrosj]

In 60150:

Editor: Restore static properties for deprecated __experimentalLinkControl.

[59775] resulted in a backwards compatibility break in a now deprecated experimental component, which was stabilized to LinkControl. When experimental components are deprecated in favor of being stabilized, the same backwards compatibility policy applies and the shape of the component should not change.

This restores the static properties that were unintentionally removed from the __experimentalLinkControl component that was moved to DeprecatedExperimentalLinkControl.

Props karthikeya01, mamaduka, joemcgill, fabiankaegy, wildworks.
Fixes #62887.

[desrosj]

Reopening to consider backporting [60150].

[joemcgill]

Thanks @desrosj. I've updated trunk locally with the new packages and tested to confirm that calling wp.blockEditor.__experimentalLinkControl.DEFAULT_LINK_SETTINGS does not result in an error.

Looks good to backport to 6.8.

[wildworks]

@desrosj Thanks for the update. I've tested trunk locally and works as expected.

[desrosj]

In 60156:

Editor: Restore static properties for deprecated __experimentalLinkControl.

[59775] resulted in a backwards compatibility break in a now deprecated experimental component, which was stabilized to LinkControl. When experimental components are deprecated in favor of being stabilized, the same backwards compatibility policy applies and the shape of the component should not change.

This restores the static properties that were unintentionally removed from the __experimentalLinkControl component that was moved to DeprecatedExperimentalLinkControl.

Reviewed by joemcgill, wildworks.
Merges [60150] to the 6.8 branch.

Props karthikeya01, mamaduka, joemcgill, fabiankaegy, wildworks.
Fixes #62887.