Fix JavaScript linting scripts

[desrosj]

The lint:jsdoc and lint:jsdoc:fix scripts are currently broken.

These should get fixed.

Additionally, the related ink-docstrap direct dependency has not been updated in 7+ years. Under the hood, these scripts use wp-scripts so ink-docstrap may not even be necessary anymore. Ideally we are able to trim this dependency if the results are styled using other means in wp-scripts.

ink-docstrap was introduced in [41351], and the scripts were switched to using wp-scripts in [48650].

Trac ticket: #62935

## Description
This PR updates the wp-prettier dependency from version 2.6.2 to 3.0.3 and refines the ESLint ignore patterns for better build management. The changes aim to fix the issues with lint:jsdoc and lint:jsdoc:fix scripts.

## Changes proposed in this Pull Request

• Upgrade wp-prettier from 2.6.2 to 3.0.3 to resolve JS linting issues
• Update .eslintignore patterns to be more specific:
  • Add build-module and build-types directories
  • Replace /build with build for consistency
  • Add *.min.js pattern to ignore minified files
  • Update wp-includes JS ignore pattern

## Testing Instructions

1. Run npm install to update dependencies
2. Run npm run lint:jsdoc to verify linting works
3. Run npm run lint:jsdoc:fix to verify auto-fixing works
4. Verify that build directories are properly ignored

## Screenshots

[ankitkumarshah]

Hi @desrosj,
I have tried a solution and opened a PR that potentially resolves the issue could you please review and test it at your convenience.

Thank you!

@Infinite-Null Taking a look at this, the update of wp-prettier seems to be the only thing necessary. Can you explain why you think we also need to "Update .eslintignore patterns to be more specific"

Hi @aaronjorbin,

Thank you for your feedback! I added those ignore rules because when I ran npm run lint:jsdoc -- --debug, I noticed that it was also running for .min.js files and build directories like src/wp-content/plugins/gutenberg/build. Since these files are not meant for linting, I believed excluding them would be appropriate.

Please guide me if I am wrong.

Thanks for the quick response and explanation.

I think bringing .eslintignore more inline with .gitignore will make more sense. For example, the ​`# Files and folders that get created in wp-content` section can be used to block any plugins code from being scanned.

​`# Files and folders related to build/test tools`
contains a number of folders worth excluding as well since those aren't being directly edited as a part of core development.

Hi @aaronjorbin,
Thanks for the feedback! I’ve updated .eslintignore to better align with .gitignore. Please review the changes and let me know if any further adjustments are needed.

Hi @aaronjorbin,
Thank you for the feedback!
I have made the changes, please review it at your convenience.

[jorbin]

ink-docstrap was put in for the purposes of creating documentation that could live on developer.wordpress.org but it looks like that has stalled. See ​https://meta.trac.wordpress.org/ticket/3063

I don't know if removing it needs to be a part of this or if there are folks using it, but moving this ticket into 6.8 since fixing the eslinting is better done sooner than later.

[jorbin]

In 59848:

Build/Test: Fix JavaScript linting scripts

wp-prettier was out of date and no longer compatible with wp-scripts. Additionally, many generated files and plugins were not being properly ignored which could cause linting to take so long that it was basically unusable.

Props ankitkumarshah, jorbin.
See #62935.

Committed in https://core.trac.wordpress.org/changeset/59848

Thanks @Infinite-Null !

[jorbin]

@desrosj Do you still think ink-docstrap needs to be addressed? I think we are fine keeping it as is

[desrosj]

My motivation around suggesting we eliminate or replace that package is that there are currently a small handful of minor vulnerabilities within transitive dependencies being privately reported by Dependabot that cannot be resolved due to version constraints within ink-docstrap.

[jorbin]

In 59935:

Build/Test: Remove unused ink-docstrap.

jsdoc is not currently in use and this theme for it is very out of date. There are currently a small handful of minor vulnerabilities within transitive dependencies being privately reported by Dependabot that cannot be resolved due to version constraints within ink-docstrap. While this in no way affects WordPress (since this code is not used by WordPress), it does create noise which can be eliminated.

This was first added in [41351] as a part of #41682.

Props desrosj.
Fixes #62935.

[johnbillion]

@jorbin @desrosj If jsdoc isn't being used shall we just go ahead and remove it? The npm run grunt jsdoc command successfully creates the docs but also exits with a bunch of parse errors.

[ankitkumarshah]

I think it is safe to remove jsdoc. Would love to work on this after hearing from @jorbin and @desrosj.

[desrosj]

I don't know that we should remove jsdoc. There are two linting scripts that use wp-scripts in package.json. If we were to remove jsdoc as a direct dependency and Grunt, we should figure out what the differences are and how to synchronize the configurations.