WordPress.org
Get WordPress

Make WordPress Core

Opened 5 weeks ago

Closed 2 weeks ago

#62936 closed defect (bug) (fixed)

Twenty Fifteen: update aria attributes on primary menu

Reported by: bschneidewind's profile bschneidewind Owned by: joedolson's profile joedolson
Milestone: 6.8 Priority: normal
Severity: normal Version: 4.1
Component: Bundled Theme Keywords: has-patch has-testing-info commit
Focuses: accessibility Cc:

Description

On the 2015 theme, when a child menu item is the currently active item, the menu will be expanded by default - however the aria-expanded attribute remains false and the aria-expanded attribute toggles the incorrect value when opened/closed.

Attachments (4)

62936-menu-open.png​ (272.3 KB) - added by dhruvang21 5 weeks ago.
62936-menu-close.png​ (255.9 KB) - added by dhruvang21 5 weeks ago.
before-patch.png​ (72.8 KB) - added by shailu25 3 weeks ago.
Before Patch.
after-patch.png​ (75.5 KB) - added by shailu25 3 weeks ago.
After Patch.

Download all attachments as: .zip

Change History (15)

This ticket was mentioned in ​PR #8290 on ​WordPress/wordpress-develop by ​@bschneidewind.
5 weeks ago #1

  • Keywords has-patch added

On the 2015 theme, when a child menu item is the currently active page the menu will be expanded by default - however the aria-expanded attribute remains false and attribute toggles the incorrect value when opened/closed.

Trac ticket: https://core.trac.wordpress.org/ticket/62936

#2 @bschneidewind
5 weeks ago

  • Summary changed from Twenty Fifteen: aria-expanded on active child menu item to Twenty Fifteen: update aria attributes on primary menu

Updated to include the aria-controls attributes

This ticket was mentioned in ​Slack in #accessibility by joedolson. ​View the logs.
5 weeks ago

#4 @joedolson
5 weeks ago

  • Milestone changed from Awaiting Review to 6.8
  • Owner set to joedolson
  • Status changed from new to accepted
  • Version set to 4.1

#5 @dhrumilk
5 weeks ago

  • Keywords needs-testing added

#6 @dhruvang21
5 weeks ago

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: ​https://github.com/WordPress/wordpress-develop/pull/8290

Environment

  • WordPress: 6.8-alpha-59274-src
  • PHP: 8.2.22
  • Server: nginx/1.27.0
  • Database: mysqli (Server: 8.0.39 / Client: mysqlnd 8.2.22)
  • Browser: Chrome 128.0.0.0
  • OS: Linux
  • Theme: Twenty Fifteen 3.9
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.0

Actual Results

  1. ✅ Issue resolved with patch.

Supplemental Artifacts

Added as Attachment

@dhruvang21
5 weeks ago

@dhruvang21
5 weeks ago

#7 @dhrumilk
5 weeks ago

  • Keywords has-testing-info added; needs-testing removed

#8 @pooja1210
3 weeks ago

Hi,

Test Report
Patch Tested: ​https://github.com/WordPress/wordpress-develop/pull/8290

Environment:
Browser: Chrome
WordPress: v6.8 alpha
PHP version: 7.4.31-dev

Result: The Aria attributes are getting updated on expand/collapse the menu item.

Screenshots:

​https://ibb.co/kV7QXMMH
​https://ibb.co/5XJjs8qM

Thanks

#9 @shailu25
3 weeks ago

Test Report

Patch Tested: ​https://github.com/WordPress/wordpress-develop/pull/8290

Environment:
WordPress - 6.8 Alpha
OS - Windows
Browser - Firefox
Theme: Twenty Fifteen
PHP - 8.2.12
Active Plugin: None

Actual Results:

  • Issue Resolved with patch.✅

Screenshots:

  • Added Attachment
Last edited 3 weeks ago by shailu25 (previous) (diff)

@shailu25
3 weeks ago

Before Patch.

@shailu25
3 weeks ago

After Patch.

#10 @joedolson
2 weeks ago

  • Keywords commit added

Looks good - marking for commit!

#11 @joedolson
2 weeks ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 59916:

Bundled Themes: Twenty Fifteen: Fix ARIA expanded in primary menu.

Set aria-expanded to true when automatically expanding active child menus in the primary menu. Add aria-controls to explicitly define controlled content in menus.

Props bschneidewind, joedolson, dhruvang21, pooja1210, shailu25.
Fixes #62936.

Note: See TracTickets for help on using tickets.