WordPress.org
Get WordPress

Make WordPress Core

Opened 6 weeks ago

Closed 5 weeks ago

#62937 closed enhancement (duplicate)

Bundled Themes: Remove IE support

Reported by: bschneidewind's profile bschneidewind Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: performance Cc:

Description

Bundled themes twentyeleven through twentyseventeen contain IE support.

Change History (5)

This ticket was mentioned in ​PR #8292 on ​WordPress/wordpress-develop by ​@bschneidewind.
6 weeks ago #1

  • Keywords has-patch added

Removes legacy IE support in bundled themes TwentyEleven - TwentySeventeen

Trac ticket: https://core.trac.wordpress.org/ticket/62937

#3 @bschneidewind
6 weeks ago

Thanks @sabernhardt ~ hadn't realized you already had the ball rolling on these!

Had a general question for you just for future reference, is it typically best to break each of those themes into their own PR on an update like this?

#4 @desrosj
5 weeks ago

  • Focuses sustainability removed
  • Milestone changed from Awaiting Review to Future Release

@bschneidewind it could help for testing purposes to have smaller PRs to review.

#5 @sabernhardt
5 weeks ago

  • Milestone Future Release deleted
  • Resolution set to duplicate
  • Status changed from new to closed

I'm closing this to keep discussion on #58836 (and #62128 for Genericons changes).

The themes need to keep the handles for each resource, registered without enqueuing, and the files should not be deleted. Replacing the contents of each legacy file with a ​single-line comment could be fine, though, if you want to advocate for that on #58836.

For the question of separating PRs, I tend to put multiple themes together in one PR, especially if the changes are small and/or very similar. However, reviewing a large PR can be tiring. If in doubt, creating a separate PR for each theme is likely better.

Note: See TracTickets for help on using tickets.