WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#6296 closed defect (bug) (fixed)

RTL CSS for 2.5

Reported by: nbachiyski Owned by:
Milestone: 2.6 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: Cc:

Description

Prepared by Mani Monajjemi.

Attachments (7)

rtl-for-25.diff (8.3 KB) - added by nbachiyski 6 years ago.
wp-admin-rtl.zip (7.7 KB) - added by nbachiyski 6 years ago.
The whole zip will be more convinient.
wp-admin-rtl-edit2.patch (3.3 KB) - added by mani_monaj 6 years ago.
New Improvements
colors-rtl-fix.patch (467 bytes) - added by mani_monaj 6 years ago.
Colors RTL fix
wp-admin-rtl-edit3.patch (6.4 KB) - added by mani_monaj 6 years ago.
Improvements
wp-admin-rtl-edit4.patch (1.5 KB) - added by mani_monaj 6 years ago.
kubrick-rtl.css (1.7 KB) - added by mani_monaj 6 years ago.
New Kubrik's rtl.css

Download all attachments as: .zip

Change History (28)

nbachiyski6 years ago

nbachiyski6 years ago

The whole zip will be more convinient.

comment:1 ryan6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [7398]) RTL CSS from Mani. fixes #6296

mani_monaj6 years ago

New Improvements

comment:2 mani_monaj6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

I added a patch. It improves some bugs on IE & Upload Page.

comment:3 ryan6 years ago

(In [7476]) RTL CSS from mani_monaj. see #6296

comment:4 follow-up: ryan6 years ago

I'm not sure if the colors rtl css is being loaded correctly. I think wp_admin_css_uri() needs to be fixed.

comment:5 in reply to: ↑ 4 mani_monaj6 years ago

Replying to ryan:

I'm not sure if the colors rtl css is being loaded correctly. I think wp_admin_css_uri() needs to be fixed.

I've just fixed it, I attached the patch.

mani_monaj6 years ago

Colors RTL fix

comment:6 ryan6 years ago

(In [7477]) Fix loading of colors RTL css. Props mani_monaj. see #6296

comment:7 mani_monaj6 years ago

Could you please ignore wp-admin-rtl-edit3.patch and let me fix all issues and submit the final patch instead.

comment:8 ryan6 years ago

see #6365 for some more RTL work

comment:9 follow-up: ryan6 years ago

Mani, take a look at #6365 and see if you can incorporate those changes.

comment:10 in reply to: ↑ 9 mani_monaj6 years ago

Replying to ryan:

Mani, take a look at #6365 and see if you can incorporate those changes.

Sure, I'll take a look and try to merge the changes and prepare the final patch.

comment:11 mani_monaj6 years ago

I manually merged our new patches with proposed changes in #6365 and attached the file. The only issue is the default font for RTL which has been leaved as Tahoma.

The RTL now looks good both on Firefox and IE7.

The remaining issues in RTL mode are:

  1. The RSS/Text widgets in widget page; When opening the widget edit panel:

In Firefox: The box becomes bigger than standard column size.
In IE7: The box disappears!

  1. In pages with lists and delete button (e.g. manage links), when hovering the delete button, the whole table moves some pixels to left

mani_monaj6 years ago

Improvements

comment:12 ryan6 years ago

(In [7494]) RTL fixes from mani_monaj and RanYanivHartstein. see #6296 #6365

comment:13 mani_monaj6 years ago

@Ryan

The file theme-editor-rtl.css is not in changeset [7494]. Were there any problems with that file?

comment:14 ryan6 years ago

(In [7501]) RTL fixes from mani_monaj and RanYanivHartstein?. see #6296 #6365

comment:15 ryan6 years ago

I forgot to svn add theme-editor-rtl.css.

comment:16 thee176 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:17 mani_monaj6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

As some original CSS files changed, I attached a new patch.

comment:18 ryan6 years ago

(In [7552]) RTL fixes from mani_monaj. see #6296

comment:19 mani_monaj6 years ago

We wrote a new rtl.css file for Kubrik, I attach this file too, it is completely different from the kubrik's original rtl.css file.

mani_monaj6 years ago

New Kubrik's rtl.css

comment:20 ryan6 years ago

(In [7553]) Updated RTL for default theme from mani_monaj. see #6296

comment:21 ryan6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.