Twenty Twelve: Skip link located after menu button.

[joedolson]

The skip link should be the first focusable object in the page; it's disorienting for it to appear in any other order. In this case, it literally means that on mobile the Skip link doesn't skip anything by default, because there is no content between the skip link and the main content.

Hey @sabernhardt Thanks for the suggestions!

I have also updated the changes and moved the skip links inside the page div for the ​Twenty Thirteen and ​Twenty Fourteen themes. Please let me know if the changes look good to you whenever you have time.

Thanks.

[krupajnanda]

Hello

I have tested the PR for 2013 theme with playground and the added fix looks good to me.

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: ​https://github.com/WordPress/wordpress-develop/pull/8327

Environment

• WordPress: 6.8-alpha-20250217.044510
• PHP: 7.4.31-dev
• Server: PHP.wasm
• Database: WP_SQLite_Translator (Server: 5.5 / Client: 3.40.1)
• Browser: Chrome 133.0.0.0
• OS: macOS
• Theme: Twenty Thirteen 4.3
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.2.0

Actual Results

1. ✅ Issue resolved with patch.

Additional test

The added fix has also been verified with responsive mode.

Supplemental Artifacts

Add as Attachment

[vgnavada]

Hi, I've tested the TWENTY FOURTEEN & TWENTY TWELVE theme with the added fix on Playground and it is working as expected.

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested:
THEME 2014 - ​https://github.com/WordPress/wordpress-develop/pull/8326
THEME 2012 - ​https://github.com/WordPress/wordpress-develop/pull/8328

Environment

• WordPress: 6.8-alpha-20250217.045205
• PHP: 7.4.31-dev
• Server: PHP.wasm
• Database: WP_SQLite_Translator (Server: 5.5 / Client: 3.40.1)
• Browser: Chrome 132.0.0.0
• OS: macOS
• Theme: Twenty Fourteen 4.1
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.2.0

Actual Results

1. ✅ Issue resolved with patch.

Additional Notes

• Also checked in responsive mode and it's working as expected

Supplemental Artifacts

Add as Attachment

[vgnavada]

TWENTY FOURTEEN - BEFORE

[vgnavada]

TWENTY FOURTEEN - AFTER

[vgnavada]

TWENTY FOURTEEN - AFTER - RESPONSIVE

[shailu25]

Test Report

Patch Tested: ​https://github.com/WordPress/wordpress-develop/pull/8328

Environment:
WordPress - 6.8-alpha-20250217.044510
OS - Windows
Browser - Firefox
Theme: Twenty Twelve
PHP - 8.2.12
Active Plugin: None

Actual Results:

• Issue Resolved with patch.✅

Screenshot:

• Added Attachment

[shailu25]

After Patch.

[joedolson]

In [59912]:

Bundled Themes: Twenty Twelve: Move skip link to top of body.

Move the skip link to the top of the body content, so it is the first focusable item on the page.

Props joedolson, sabernhardt, abcd95, vgnavada, shailu25.
Fixes #62967.

Merged in the changeset - [59912]

I planned to gather screenshots, and they look fine in Twenty Twelve.

Before r59912:

Twenty Twelve now inherits a few styles from block-library/style.css, and the skip links are still in the top corner.

line-height: normal;
text-decoration: none;
margin: -1px;