Make WordPress Core

Opened 5 months ago

Closed 4 months ago

Last modified 4 months ago

#62968 closed defect (bug) (fixed)

Twenty Thirteen: Skip link out of order

Reported by: joedolson's profile joedolson Owned by: joedolson's profile joedolson
Milestone: 6.8 Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: good-first-bug has-patch commit
Focuses: accessibility Cc:

Description

The skip link should be the first focusable object in the page; it's disorienting for it to appear in any other order. In this case, like in Twenty Twelve, it means that on mobile the Skip link doesn't skip anything by default, because there is no content between the skip link and the main content.

Attachments (1)

twenty-thirteen-after-patch.png (183.2 KB) - added by shailu25 5 months ago.
After Patch.

Download all attachments as: .zip

Change History (11)

This ticket was mentioned in PR #8327 on WordPress/wordpress-develop by @abcd95.


5 months ago
#1

  • Keywords has-patch added

#2 @shanemuir
5 months ago

  • Keywords needs-testing added

#3 @joedolson
5 months ago

  • Owner set to joedolson
  • Status changed from new to accepted

#4 @manojmaharrshi
5 months ago

Test Report

Description

This report validates the patch for skip link to move up the order

Patch tested: https://patch-diff.githubusercontent.com/raw/WordPress/wordpress-develop/pull/8327.diff

Environment

  • WordPress: 6.8-alpha-59840
  • PHP: 8.1.29
  • Server: nginx/1.16.0
  • Database: mysqli (Server: 8.0.16 / Client: mysqlnd 8.1.29)
  • Browser: Chrome 133.0.0.0
  • OS: macOS
  • Theme: Twenty Thirteen 4.3
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.0
    • WordPress Beta Tester 3.6.2

Actual Results

  1. ✅ Issue resolved with patch.

#5 @shailu25
5 months ago

Test Report

Patch Tested: https://github.com/WordPress/wordpress-develop/pull/8327

Environment:
WordPress - 6.7.2
OS - Windows
Browser - Firefox
Theme: Twenty Thirteen
PHP - 8.2.12
Active Plugin: None

Actual Results:

  • Issue Resolved with patch.✅

Screenshot:

  • Added Attachment

@shailu25
5 months ago

After Patch.

@abcd95 commented on PR #8327:


4 months ago
#6

Hey @audrasjb @sabernhardt, could you please review the changes in the PR and let me know if they look good to you whenever you have a moment?

Thanks.

Similar PRs - https://github.com/WordPress/wordpress-develop/pull/8328, https://github.com/WordPress/wordpress-develop/pull/8326

@audrasjb commented on PR #8327:


4 months ago
#7

I can confirm this PR fixes the issue: the skip link is the first focusable item on the page.
https://github.com/user-attachments/assets/64574046-b7e4-43ed-a8c1-1b23b49ee1a5

#8 @audrasjb
4 months ago

  • Keywords commit added; needs-testing removed

Marking this for commit.

#9 @joedolson
4 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 59913:

Bundled Themes: Twenty Thirteen: Move skip link to top of body.

Move the skip link to the top of the body content, so it is the first focusable item on the page.

Props joedolson, sabernhardt, abcd95, manojmaharrshi, shailu25, audrasjb, krupajnanda.
Fixes #62968.

@sabernhardt commented on PR #8327:


4 months ago
#10

I planned to gather screenshots, and they look good for Twenty Thirteen.

Before r59913, the skip link was positioned in front of the main navigation menu.

https://github.com/user-attachments/assets/8bffd82d-76d5-4380-9167-668f8559d788

Now the link appears in the top corner.

https://github.com/user-attachments/assets/9e36b723-6f63-4235-bfdb-2bfa750102d4

Note: See TracTickets for help on using tickets.