Make WordPress Core

#62971 closed defect (bug) (fixed)

Change casing in admin bar for "Edit site"

Reported by: bronsonquick Owned by: audrasjb
Priority: normal Milestone: 6.8
Component: Toolbar Version: 5.9
Severity: minor Keywords: has-patch
Cc: Focuses: administration

Description

All other words in the admin bar use uppercase so we should change "Edit site" to be "Edit Site" for consistency. This was originally introduced in this ticket: https://core.trac.wordpress.org/changeset/52158

https://s3.amazonaws.com/bronsons-captured/Monosnap_Privacy_Policy__Chassis_Site_2025-02-16_09-00-07.jpg

Attachments (1)

62971.diff (783 bytes ) - added by bronsonquick 18 months ago.

Download all attachments as: .zip

Change History (10)

@bronsonquick
18 months ago

#1 @sabernhardt
18 months ago

  • Component AdministrationToolbar

Related discussions are on #60977 and #62368.

#2 @audrasjb
18 months ago

  • Owner set to audrasjb
  • Status newaccepted

Hello and thank you for the ticket,

This change is different from the things pointed out by the related tickets @sabernhardt pointed out, so let's milestone it for 6.8.

#3 @audrasjb
18 months ago

  • Milestone Awaiting Review6.8

#4 follow-up: @peterwilsoncc
18 months ago

site-editor.php also includes the sentence case Edit site as a heading when the error message displays due to a lack of JavaScript (code reference).

As all the other page headings in the dashboard use title case, let's change that too.

@audrasjb to aid translation teams, do you recommend a context be added to differentiate the page heading from the admin bar link?

#5 in reply to: ↑ 4 @audrasjb
18 months ago

Replying to peterwilsoncc:

@audrasjb to aid translation teams, do you recommend a context be added to differentiate the page heading from the admin bar link?

Yes this is 100% recommended in this case :)

#6 @peterwilsoncc
18 months ago

@bronsonquick Do you have time to fix the site heading and upload a new patch?

I recommend the following for each of the strings respectively

_x( 'Edit Site', 'site editor link from admin bar' )
_x( 'Edit Site', 'site editor heading' )

#7 @adamsilverstein
18 months ago

Related fix for "Collapse menu" -> "Collapse Menu" - https://core.trac.wordpress.org/ticket/59133

#9 @audrasjb
18 months ago

  • Resolutionfixed
  • Status acceptedclosed

In 59850:

Administration: Capitalize "Edit Site" strings for consistency.

This changeset brings more consistency by capitalizing the "Edit Site" strings located in the Toolbar and on the Site Editor screen.

Props bronsonquick, sabernhardt, audrasjb, peterwilsoncc, adamsilverstein.
Fixes #62971.

Note: See TracTickets for help on using tickets.