Opened 5 weeks ago
Closed 4 weeks ago
#62971 closed defect (bug) (fixed)
Change casing in admin bar for "Edit site"
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.8 | Priority: | normal |
Severity: | minor | Version: | 5.9 |
Component: | Toolbar | Keywords: | has-patch |
Focuses: | administration | Cc: |
Description
All other words in the admin bar use uppercase so we should change "Edit site" to be "Edit Site" for consistency. This was originally introduced in this ticket: https://core.trac.wordpress.org/changeset/52158
Attachments (1)
Change History (10)
#2
@
5 weeks ago
- Owner set to audrasjb
- Status changed from new to accepted
Hello and thank you for the ticket,
This change is different from the things pointed out by the related tickets @sabernhardt pointed out, so let's milestone it for 6.8.
#4
follow-up:
↓ 5
@
5 weeks ago
site-editor.php
also includes the sentence case Edit site
as a heading when the error message displays due to a lack of JavaScript (code reference).
As all the other page headings in the dashboard use title case, let's change that too.
@audrasjb to aid translation teams, do you recommend a context be added to differentiate the page heading from the admin bar link?
#5
in reply to:
↑ 4
@
5 weeks ago
Replying to peterwilsoncc:
@audrasjb to aid translation teams, do you recommend a context be added to differentiate the page heading from the admin bar link?
Yes this is 100% recommended in this case :)
#6
@
5 weeks ago
@bronsonquick Do you have time to fix the site heading and upload a new patch?
I recommend the following for each of the strings respectively
_x( 'Edit Site', 'site editor link from admin bar' ) _x( 'Edit Site', 'site editor heading' )
#7
@
5 weeks ago
Related fix for "Collapse menu" -> "Collapse Menu" - https://core.trac.wordpress.org/ticket/59133
Related discussions are on #60977 and #62368.