Fatal error in twentyfourteen_paging_nav()

[takayukister]

You get the following error when you access the home page with GET variables in the array format. Example:

/?test[]=1

Fatal error: Uncaught TypeError: urlencode(): Argument #1 ($string) must be of type string, array given in /wp-content/themes/twentyfourteen/inc/template-tags.php:50

Stack trace:
#0 [internal function]: urlencode(Array)
#1 /wp-content/themes/twentyfourteen/inc/template-tags.php(50): array_map('urlencode', Array)
#2 /wp-content/themes/twentyfourteen/index.php(46): twentyfourteen_paging_nav()
#3 /wp-includes/template-loader.php(106): include('/Users/...')
#4 /wp-blog-header.php(19): require_once('/test...')
#5 /index.php(17): require('/test...')
#6 {main} thrown in /wp-content/themes/twentyfourteen/inc/template-tags.php on line 50

This error occurs because twentyfourteen_paging_nav() does not expect array variables.

A possible fix for this would be replacing array_map( 'urlencode', $query_args ) with urlencode_deep( $query_args ).

[pratiklondhe]

hi, @takayukister , I tried to replicate this on fresh WP install and twentyfourteen theme but couldn't, I am able to access the homepage even withe the ?test[]=1 get parameter without error, is there some steps I am missing here ?

ps : attached a video of how I tested

[takayukister]

@pratiklondhe Maybe that is because you don't have enough number of posts. If you have 11 or more posts to show, twentyfourteen_paging_nav() will be used and the error will occur.

[pratiklondhe]

@takayukister , Yes, after adding 12 posts and testing again, I could replicate the issue.
I've implemented the changes you suggested, which appear to have resolved the error. Attaching the patch for review.

[audrasjb]

Thanks for the ticket, moving this to milestone 6.8.

[rinkalpagdar]

I have activated the twentyfourteen theme and also have 12 posts but couldn't able to reproduce the issue. Please let me know if I am missing anything here.

[pratiklondhe]

Hey, @rinkalpagdar. Thanks for attempting to reproduce this!
Ideally, the homepage should display a list of posts. Could you check the backend settings by navigating to Settings → Reading → "Your homepage displays" and confirm that it's set to "Your latest posts" instead of a static page?

[rinkalpagdar]

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/62972/62972.diff

Environment

• WordPress: 6.8-alpha-59274-src
• PHP: 8.2.25
• Server: nginx/1.27.2
• Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.25)
• Browser: Chrome 133.0.0.0
• OS: macOS
• Theme: Twenty Fourteen 4.1
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.2.0

Actual Results

1. ✅ Issue resolved with patch.

[audrasjb]

In 59851:

Bundled Themes: Prevent a fatal error occurring with Twenty Fourteen paginated navigation.

This changeset replaces array_map( 'urlencode', $query_args ) with urlencode_deep( $query_args ) in twentyfourteen_paging_nav() to prevent a fatal error when an array is provided in the query vars.

Props takayukister, pratiklondhe, rinkalpagdar.
Fixes #62972.